Update README for Homebrew. #3991

Hoverbear · 2014-11-15T02:47:02Z

glfw3 is in the homebrew/versions keg.

➜  ~  brew install glfw3
Error: No available formula for glfw3
Searching formulae...
Searching taps...
homebrew/versions/glfw3

Simplest fix:

➜  ~  brew install homebrew/versions/glfw3
Cloning into '/usr/local/Library/Taps/homebrew/homebrew-versions'...
remote: Counting objects: 2495, done.
remote: Total 2495 (delta 0), reused 0 (delta 0)
Receiving objects: 100% (2495/2495), 820.05 KiB | 462.00 KiB/s, done.
Resolving deltas: 100% (1433/1433), done.
Checking connectivity... done.
Tapped 161 formulae
==> Installing glfw3 from homebrew/homebrew-versions
==> Downloading https://downloads.sourceforge.net/project/glfw/glfw/3.0.4/glfw-3.0.4.tar.bz2
Already downloaded: /Library/Caches/Homebrew/glfw3-3.0.4.tar.bz2
==> Patching
patching file CMakeLists.txt
Hunk #1 succeeded at 370 with fuzz 1 (offset 13 lines).
==> cmake -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/glfw3/3.0.4 -DCMAKE_BUILD_TYPE=None -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_VERBOSE_MAKEFILE=ON -Wno-dev -DGLFW_USE_CHDIR=TRUE -DGLFW_USE_MENUBAR=TRUE -DBUIL
==> make install
🍺  /usr/local/Cellar/glfw3/3.0.4: 11 files, 220K, built in 9 seconds

Users who have homebrew/versions already tapped won't notice this, since after tapping homebrew/versions keg shouldn't notice, since after tapping, the library is available using just brew install glfw3.

➜  ~  brew tap
homebrew/versions
➜  ~  brew install glfw3
==> Installing glfw3 from homebrew/homebrew-versions
==> Downloading https://downloads.sourceforge.net/project/glfw/glfw/3.0.4/glfw-3.0.4.tar.bz2
Already downloaded: /Library/Caches/Homebrew/glfw3-3.0.4.tar.bz2
==> Patching
patching file CMakeLists.txt
Hunk #1 succeeded at 370 with fuzz 1 (offset 13 lines).
==> cmake -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/glfw3/3.0.4 -DCMAKE_BUILD_TYPE=None -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_VERBOSE_MAKEFILE=ON -Wno-dev -DGLFW_USE_CHDIR=TRUE -DGLFW_USE_MENUBAR=TRUE -DBUIL
==> make install
🍺  /usr/local/Cellar/glfw3/3.0.4: 11 files, 220K, built in 9 seconds

hoppipolla-critic-bot · 2014-11-15T02:47:06Z

Critic review: https://critic.hoppipolla.co.uk/r/3174

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

jdm · 2014-11-15T06:14:25Z

There's a similar PR in #3895, but we actually should just remove glfw3 from the prerequisites entirely since it is no longer needed. Could you do that instead?

Hoverbear · 2014-11-15T06:42:48Z

@jdm Yup. I pulled it from the other parts of the README.md too.

jdm · 2014-11-15T15:25:18Z

Thanks!

jdm · 2014-11-16T04:16:17Z

Hmm, looks like this need a rebase. Sorry.

Hoverbear · 2014-11-16T05:57:38Z

Should be better.

jdm · 2014-11-16T14:15:17Z

Still can't merge for some reason :/

jdm · 2014-11-16T14:15:54Z

The reason being that the commit now includes a bunch of sniffer-related code in net/.

Hoverbear · 2014-11-16T16:24:48Z

Oy, yeah, what the heck.


         Update README for Homebrew.

glfw3 is in the `homebrew/homebrew-versions` repository.

Hoverbear · 2014-11-16T16:30:42Z

@jdm Sorry about that. Should be happy now. Oh the folly of git rebase -i.

jdm · 2014-11-16T16:53:04Z

r+

jdm · 2014-11-17T14:08:08Z

@bors: retry

bors-servo · 2014-11-16T16:54:26Z

saw approval from jdm
at Hoverbear@3b2fcb0

bors-servo · 2014-11-16T16:54:27Z

merging Hoverbear/servo/patch-1 = 3b2fcb0 into auto

bors-servo · 2014-11-16T16:54:27Z

Hoverbear/servo/patch-1 = 3b2fcb0 merged ok, testing candidate = 4a5b704

bors-servo · 2014-11-16T17:18:29Z

some tests failed:
failure: http://build.servo.org/builders/linux/builds/652

bors-servo · 2014-11-17T14:21:28Z

saw approval from jdm
at Hoverbear@3b2fcb0

bors-servo · 2014-11-17T14:21:29Z

merging Hoverbear/servo/patch-1 = 3b2fcb0 into auto

bors-servo · 2014-11-17T14:21:29Z

Hoverbear/servo/patch-1 = 3b2fcb0 merged ok, testing candidate = b9dcaa3

bors-servo · 2014-11-17T14:48:29Z

all tests pass:
success: http://build.servo.org/builders/linux/builds/670
success: http://build.servo.org/builders/mac1/builds/212
success: http://build.servo.org/builders/mac2/builds/212

bors-servo · 2014-11-17T14:51:31Z

fast-forwarding master to auto = b9dcaa3


        auto merge of #3991 : Hoverbear/servo/patch-1, r=jdm

glfw3 is in the `homebrew/versions` keg. ```bash ➜ ~ brew install glfw3 Error: No available formula for glfw3 Searching formulae... Searching taps... homebrew/versions/glfw3 ``` Simplest fix: ```bash ➜ ~ brew install homebrew/versions/glfw3 Cloning into '/usr/local/Library/Taps/homebrew/homebrew-versions'... remote: Counting objects: 2495, done. remote: Total 2495 (delta 0), reused 0 (delta 0) Receiving objects: 100% (2495/2495), 820.05 KiB | 462.00 KiB/s, done. Resolving deltas: 100% (1433/1433), done. Checking connectivity... done. Tapped 161 formulae ==> Installing glfw3 from homebrew/homebrew-versions ==> Downloading https://downloads.sourceforge.net/project/glfw/glfw/3.0.4/glfw-3.0.4.tar.bz2 Already downloaded: /Library/Caches/Homebrew/glfw3-3.0.4.tar.bz2 ==> Patching patching file CMakeLists.txt Hunk #1 succeeded at 370 with fuzz 1 (offset 13 lines). ==> cmake -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/glfw3/3.0.4 -DCMAKE_BUILD_TYPE=None -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_VERBOSE_MAKEFILE=ON -Wno-dev -DGLFW_USE_CHDIR=TRUE -DGLFW_USE_MENUBAR=TRUE -DBUIL ==> make install 🍺 /usr/local/Cellar/glfw3/3.0.4: 11 files, 220K, built in 9 seconds ``` Users who have `homebrew/versions` already tapped won't notice this, since after tapping `homebrew/versions` keg shouldn't notice, since after tapping, the library is available using just ` brew install glfw3`. ```bash ➜ ~ brew tap homebrew/versions ➜ ~ brew install glfw3 ==> Installing glfw3 from homebrew/homebrew-versions ==> Downloading https://downloads.sourceforge.net/project/glfw/glfw/3.0.4/glfw-3.0.4.tar.bz2 Already downloaded: /Library/Caches/Homebrew/glfw3-3.0.4.tar.bz2 ==> Patching patching file CMakeLists.txt Hunk #1 succeeded at 370 with fuzz 1 (offset 13 lines). ==> cmake -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/glfw3/3.0.4 -DCMAKE_BUILD_TYPE=None -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_VERBOSE_MAKEFILE=ON -Wno-dev -DGLFW_USE_CHDIR=TRUE -DGLFW_USE_MENUBAR=TRUE -DBUIL ==> make install 🍺 /usr/local/Cellar/glfw3/3.0.4: 11 files, 220K, built in 9 seconds ```


        auto merge of #3991 : Hoverbear/servo/patch-1, r=jdm

glfw3 is in the `homebrew/versions` keg. ```bash ➜ ~ brew install glfw3 Error: No available formula for glfw3 Searching formulae... Searching taps... homebrew/versions/glfw3 ``` Simplest fix: ```bash ➜ ~ brew install homebrew/versions/glfw3 Cloning into '/usr/local/Library/Taps/homebrew/homebrew-versions'... remote: Counting objects: 2495, done. remote: Total 2495 (delta 0), reused 0 (delta 0) Receiving objects: 100% (2495/2495), 820.05 KiB | 462.00 KiB/s, done. Resolving deltas: 100% (1433/1433), done. Checking connectivity... done. Tapped 161 formulae ==> Installing glfw3 from homebrew/homebrew-versions ==> Downloading https://downloads.sourceforge.net/project/glfw/glfw/3.0.4/glfw-3.0.4.tar.bz2 Already downloaded: /Library/Caches/Homebrew/glfw3-3.0.4.tar.bz2 ==> Patching patching file CMakeLists.txt Hunk #1 succeeded at 370 with fuzz 1 (offset 13 lines). ==> cmake -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/glfw3/3.0.4 -DCMAKE_BUILD_TYPE=None -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_VERBOSE_MAKEFILE=ON -Wno-dev -DGLFW_USE_CHDIR=TRUE -DGLFW_USE_MENUBAR=TRUE -DBUIL ==> make install 🍺 /usr/local/Cellar/glfw3/3.0.4: 11 files, 220K, built in 9 seconds ``` Users who have `homebrew/versions` already tapped won't notice this, since after tapping `homebrew/versions` keg shouldn't notice, since after tapping, the library is available using just ` brew install glfw3`. ```bash ➜ ~ brew tap homebrew/versions ➜ ~ brew install glfw3 ==> Installing glfw3 from homebrew/homebrew-versions ==> Downloading https://downloads.sourceforge.net/project/glfw/glfw/3.0.4/glfw-3.0.4.tar.bz2 Already downloaded: /Library/Caches/Homebrew/glfw3-3.0.4.tar.bz2 ==> Patching patching file CMakeLists.txt Hunk #1 succeeded at 370 with fuzz 1 (offset 13 lines). ==> cmake -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/glfw3/3.0.4 -DCMAKE_BUILD_TYPE=None -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_VERBOSE_MAKEFILE=ON -Wno-dev -DGLFW_USE_CHDIR=TRUE -DGLFW_USE_MENUBAR=TRUE -DBUIL ==> make install 🍺 /usr/local/Cellar/glfw3/3.0.4: 11 files, 220K, built in 9 seconds ```

SimonSapin · 2014-11-20T14:20:04Z

README.md

@@ -32,7 +28,7 @@ On Debian-based Linuxes:
 sudo apt-get install curl freeglut3-dev \
    libfreetype6-dev libgl1-mesa-dri libglib2.0-dev xorg-dev \
    msttcorefonts gperf g++ cmake python-virtualenv \
-    libssl-dev libglfw-dev libbz2-dev


To clarify: bzip2 should not have been removed here and in other places.

Hoverbear · 2014-11-20T15:31:11Z

@SimonSapin Sorry about that. I didn't notice that when I was attempting to rebase. :(

SimonSapin · 2014-11-20T15:58:24Z

Don’t worry, it’s nothing we can’t fix :)

jdm mentioned this pull request Nov 15, 2014

Fix README homebrew install regarding glfw3 #3895

Closed

Hoverbear force-pushed the Hoverbear:patch-1 branch from 0a7339d to 4e747c0 Nov 16, 2014

Update README for Homebrew.

Loading status checks…

3b2fcb0

glfw3 is in the `homebrew/homebrew-versions` repository.

Hoverbear force-pushed the Hoverbear:patch-1 branch from 4e747c0 to 3b2fcb0 Nov 16, 2014

bors-servo closed this Nov 17, 2014

bors-servo merged commit 3b2fcb0 into servo:master Nov 17, 2014
1 check passed

1 check passed

default all tests passed

Hoverbear deleted the Hoverbear:patch-1 branch Nov 17, 2014

SimonSapin reviewed Nov 20, 2014
View changes

SimonSapin mentioned this pull request Nov 20, 2014

Added libbz2-dev to Debian based prerequisites #4042

Merged

servo / servo

Update README for Homebrew. #3991

Update README for Homebrew. #3991

Hoverbear commented Nov 15, 2014

hoppipolla-critic-bot commented Nov 15, 2014

jdm commented Nov 15, 2014

Hoverbear commented Nov 15, 2014

jdm commented Nov 15, 2014

jdm commented Nov 16, 2014

Hoverbear commented Nov 16, 2014

jdm commented Nov 16, 2014

jdm commented Nov 16, 2014

Hoverbear commented Nov 16, 2014

Hoverbear commented Nov 16, 2014

This comment has been minimized.

jdm commented on `3b2fcb0` Nov 16, 2014

This comment has been minimized.

jdm replied Nov 17, 2014

This comment has been minimized.

bors-servo commented on `3b2fcb0` Nov 16, 2014

This comment has been minimized.

bors-servo replied Nov 16, 2014

This comment has been minimized.

bors-servo replied Nov 16, 2014

This comment has been minimized.

bors-servo replied Nov 16, 2014

This comment has been minimized.

bors-servo replied Nov 17, 2014

This comment has been minimized.

bors-servo replied Nov 17, 2014

This comment has been minimized.

bors-servo replied Nov 17, 2014

This comment has been minimized.

bors-servo replied Nov 17, 2014

This comment has been minimized.

bors-servo replied Nov 17, 2014

This comment has been minimized.

This comment has been minimized.

Hoverbear commented Nov 20, 2014

SimonSapin commented Nov 20, 2014

servo / servo

Join GitHub today

Update README for Homebrew. #3991

Update README for Homebrew. #3991

Conversation

Hoverbear commented Nov 15, 2014

hoppipolla-critic-bot commented Nov 15, 2014

jdm commented Nov 15, 2014

Hoverbear commented Nov 15, 2014

jdm commented Nov 15, 2014

jdm commented Nov 16, 2014

Hoverbear commented Nov 16, 2014

jdm commented Nov 16, 2014

jdm commented Nov 16, 2014

Hoverbear commented Nov 16, 2014

Hoverbear commented Nov 16, 2014

This comment has been minimized.

jdm commented on 3b2fcb0 Nov 16, 2014

This comment has been minimized.

jdm replied Nov 17, 2014

This comment has been minimized.

bors-servo commented on 3b2fcb0 Nov 16, 2014

This comment has been minimized.

bors-servo replied Nov 16, 2014

This comment has been minimized.

bors-servo replied Nov 16, 2014

This comment has been minimized.

bors-servo replied Nov 16, 2014

This comment has been minimized.

bors-servo replied Nov 17, 2014

This comment has been minimized.

bors-servo replied Nov 17, 2014

This comment has been minimized.

bors-servo replied Nov 17, 2014

This comment has been minimized.

bors-servo replied Nov 17, 2014

This comment has been minimized.

bors-servo replied Nov 17, 2014

This comment has been minimized.

SimonSapin Nov 20, 2014

This comment has been minimized.

SimonSapin Nov 20, 2014

Hoverbear commented Nov 20, 2014

SimonSapin commented Nov 20, 2014

jdm commented on `3b2fcb0` Nov 16, 2014

bors-servo commented on `3b2fcb0` Nov 16, 2014