Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark vertical-lr-blocks.html as flaky to ease the pain while it's being ... #3996

Closed
wants to merge 1 commit into from

Conversation

@jdm
Copy link
Member

jdm commented Nov 15, 2014

...investigated. #3926

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 15, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3177

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger

This comment has been minimized.

Copy link
Collaborator

Ms2ger commented on a589ed7 Nov 15, 2014

r+ p=1

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on a589ed7 Nov 15, 2014

saw approval from Ms2ger
at jdm@a589ed7

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 15, 2014

merging jdm/servo/flakyvertical = a589ed7 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 15, 2014

jdm/servo/flakyvertical = a589ed7 merged ok, testing candidate = 80baba0

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 15, 2014

fast-forwarding master to auto = 80baba0

bors-servo pushed a commit that referenced this pull request Nov 15, 2014
...investigated. #3926
@bors-servo bors-servo closed this Nov 15, 2014
@pcwalton
Copy link
Contributor

pcwalton commented Nov 15, 2014

For what it's worth I think the issue may be something to do with style sharing related to the sibling selectors it uses.

@jdm jdm deleted the jdm:flakyvertical branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.