Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove '--quiet' option from git commands in /configure. #400
+5
−5
Conversation
metajack
added a commit
that referenced
this pull request
Apr 29, 2013
Remove '--quiet' option from git commands in /configure.
|
Thank you! |
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
… r=glennw Do not repeat textures in transformed image rects The way that texture coordinates were calculated meant that textures were repeated outside the bounds of transformed image primitives. Clamp to local rect boundaries in order to simulate texture clamping here. This is important for anti-aliased edges, which have subpixels outside texture boundaries. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/400) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tetsuharuohzeki commentedApr 29, 2013
Should we display information about
git submodulewhenconfigure?When I called
configureafter cloning servo repository, it resolved and initialized git sub modules. However, the firstgit submoduleafter clone the repository needs long times for initializing sub repository (e.g. skia, rust) and it doesn't display any progress about submodules. At this time, we cannot know thatconfigureworks correctly, or has some error if we uses--quietoption.I think we shouldn't use
--quietoption.