Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key[board]event args for Document#createEvent #4014

Closed
wants to merge 1 commit into from

Conversation

@ajnirp
Copy link
Contributor

ajnirp commented Nov 17, 2014

fix #4007

@Manishearth
Copy link
Member

Manishearth commented Nov 17, 2014

pokes Critic with a sharp stick

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 17, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3192

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

bors-servo pushed a commit that referenced this pull request Nov 17, 2014
@ajnirp ajnirp force-pushed the ajnirp:doc-createevent-keyevents branch from 3c78107 to 25291cf Nov 17, 2014
bors-servo pushed a commit that referenced this pull request Nov 17, 2014
@jdm
Copy link
Member

jdm commented Nov 17, 2014

In general it's preferred to remove test annotations instead of changing FAIL -> PASS.

@Manishearth
Copy link
Member

Manishearth commented Nov 17, 2014

Ah, I thought this had been autogenerated.

I guess the next time wptupdate is run this will get fixed.

@Manishearth
Copy link
Member

Manishearth commented Nov 17, 2014

@wenderen For future use, https://github.com/servo/servo/blob/master/tests/wpt/README.md#updating-test-expectations

You can run it on specific tests using --include if you don't want to run the whole suite.

@ajnirp ajnirp force-pushed the ajnirp:doc-createevent-keyevents branch 2 times, most recently from 80346a6 to aad124f Nov 17, 2014
@Manishearth

This comment has been minimized.

Copy link

Manishearth commented on aad124f Nov 17, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on aad124f Nov 17, 2014

saw approval from Manishearth
at ajnirp@aad124f

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 17, 2014

merging wenderen/servo/doc-createevent-keyevents = aad124f into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 17, 2014

wenderen/servo/doc-createevent-keyevents = aad124f merged ok, testing candidate = eeb11d6

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 17, 2014

fast-forwarding master to auto = eeb11d6

bors-servo pushed a commit that referenced this pull request Nov 17, 2014
@bors-servo bors-servo closed this Nov 17, 2014
@ajnirp ajnirp deleted the ajnirp:doc-createevent-keyevents branch Nov 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.