Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upkey[board]event args for Document#createEvent #4014
Conversation
|
pokes Critic with a sharp stick |
hoppipolla-critic-bot
commented
Nov 17, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3192 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
3c78107
to
25291cf
|
In general it's preferred to remove test annotations instead of changing FAIL -> PASS. |
|
Ah, I thought this had been autogenerated. I guess the next time wptupdate is run this will get fixed. |
|
@wenderen For future use, https://github.com/servo/servo/blob/master/tests/wpt/README.md#updating-test-expectations You can run it on specific tests using |
80346a6
to
aad124f
This comment has been minimized.
This comment has been minimized.
Manishearth
commented on aad124f
Nov 17, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Manishearth |
This comment has been minimized.
This comment has been minimized.
|
merging wenderen/servo/doc-createevent-keyevents = aad124f into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = eeb11d6 |
ajnirp commentedNov 17, 2014
fix #4007