Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHTMLScriptElementHelpers::is_javascript should compare ASCII case-insensitively #4021
Conversation
hoppipolla-critic-bot
commented
Nov 17, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3202 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
@letharion: thanks! I left some comments on critic. |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Ms2ger |
This comment has been minimized.
This comment has been minimized.
|
merging letharion/servo/Case-insensitive-HTMLScriptElementHelpers-comparision = d84c0fc into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
saw approval from Ms2ger |
This comment has been minimized.
This comment has been minimized.
|
merging letharion/servo/Case-insensitive-HTMLScriptElementHelpers-comparision = d84c0fc into auto |
This comment has been minimized.
This comment has been minimized.
|
No active merge of candidate d84c0fc found, likely manual push to master |
This comment has been minimized.
This comment has been minimized.
|
merging letharion/servo/Case-insensitive-HTMLScriptElementHelpers-comparision = d84c0fc into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 3fafd61 |
|
Closing to poke bors |
d84c0fc
into
servo:master
letharion commentedNov 17, 2014
Fix for #3993