Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLScriptElementHelpers::is_javascript should compare ASCII case-insensitively #4021

Merged
merged 1 commit into from Nov 18, 2014

Conversation

@letharion
Copy link
Contributor

letharion commented Nov 17, 2014

Fix for #3993

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 17, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3202

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 17, 2014

@letharion: thanks! I left some comments on critic.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on d84c0fc Nov 18, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

merging letharion/servo/Case-insensitive-HTMLScriptElementHelpers-comparision = d84c0fc into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

letharion/servo/Case-insensitive-HTMLScriptElementHelpers-comparision = d84c0fc merged ok, testing candidate = 2964c6a

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

merging letharion/servo/Case-insensitive-HTMLScriptElementHelpers-comparision = d84c0fc into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

No active merge of candidate d84c0fc found, likely manual push to master

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

merging letharion/servo/Case-insensitive-HTMLScriptElementHelpers-comparision = d84c0fc into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

letharion/servo/Case-insensitive-HTMLScriptElementHelpers-comparision = d84c0fc merged ok, testing candidate = 3fafd61

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

fast-forwarding master to auto = 3fafd61

bors-servo pushed a commit that referenced this pull request Nov 18, 2014
…entHelpers-comparision, r=Ms2ger

Fix for #3993
bors-servo pushed a commit that referenced this pull request Nov 18, 2014
…entHelpers-comparision, r=Ms2ger

Fix for #3993
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 18, 2014

Closing to poke bors

@Ms2ger Ms2ger closed this Nov 18, 2014
@Ms2ger Ms2ger reopened this Nov 18, 2014
bors-servo pushed a commit that referenced this pull request Nov 18, 2014
…entHelpers-comparision, r=Ms2ger

Fix for #3993
@bors-servo bors-servo closed this Nov 18, 2014
@bors-servo bors-servo merged commit d84c0fc into servo:master Nov 18, 2014
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.