Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DOMImplementation.hasFeature #4027

Merged
merged 1 commit into from Nov 18, 2014
Merged

Implement DOMImplementation.hasFeature #4027

merged 1 commit into from Nov 18, 2014

Conversation

@znewman01
Copy link
Contributor

znewman01 commented Nov 18, 2014

Fixes #4010.

This is my first Servo contribution, so let me know if I missed anything!
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 18, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3204

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@jdm
Copy link
Member

jdm commented Nov 18, 2014

Commented on Critic! Thanks!
@znewman01
Copy link
Contributor Author

znewman01 commented Nov 18, 2014

Fixed! Didn't know about that feature.
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 18, 2014

@znewman01: looking good! Please squash the three commits together, so we can merge.
@znewman01
Implement DOMImplementation.hasFeature
Loading status checks…
2399a14 
Fixes #4010.
@znewman01 znewman01 force-pushed the znewman01:issue4010 branch from a724041 to 2399a14 Nov 18, 2014
@znewman01
Copy link
Contributor Author

znewman01 commented Nov 18, 2014

@Ms2ger: squashed!
@Ms2ger

This comment has been minimized.

Sign in to view
Copy link

Ms2ger commented on 2399a14 Nov 18, 2014

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 2399a14 Nov 18, 2014

saw approval from Ms2ger
at znewman01@2399a14

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 18, 2014

merging znewman01/servo/issue4010 = 2399a14 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 18, 2014

znewman01/servo/issue4010 = 2399a14 merged ok, testing candidate = efb4fe4

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 18, 2014

all tests pass:
success: http://build.servo.org/builders/linux1/builds/6
success: http://build.servo.org/builders/linux2/builds/6
success: http://build.servo.org/builders/android/builds/73
success: http://build.servo.org/builders/mac1/builds/223
success: http://build.servo.org/builders/mac2/builds/223

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 18, 2014

fast-forwarding master to auto = efb4fe4
bors-servo pushed a commit that referenced this pull request Nov 18, 2014
bors-servo
auto merge of #4027 : znewman01/servo/issue4010, r=Ms2ger
Loading status checks…
efb4fe4 
Fixes #4010.

This is my first Servo contribution, so let me know if I missed anything!
@bors-servo bors-servo closed this Nov 18, 2014
@bors-servo bors-servo merged commit 2399a14 into servo:master Nov 18, 2014
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement DOMImplementation.hasFeature.
5 participants
@znewman01 @hoppipolla-critic-bot @jdm @Ms2ger @bors-servo
You can’t perform that action at this time.