Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate behavior of Document.createElement #4029
Conversation
hoppipolla-critic-bot
commented
Nov 18, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3208 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
You should change the commit message to |
This comment has been minimized.
This comment has been minimized.
Ms2ger
commented on a8ce3e3
Nov 18, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Ms2ger |
This comment has been minimized.
This comment has been minimized.
|
merging znewman01/servo/issue4009 = a8ce3e3 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
No active merge of candidate a8ce3e3 found, likely manual push to master |
This comment has been minimized.
This comment has been minimized.
|
merging znewman01/servo/issue4009 = a8ce3e3 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 929671f |
znewman01 commentedNov 18, 2014
Fixes #4009.
Only lower-case the argument to Document#createElement if it's a HTML document.