Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update behavior of Document.createElement #4029

Closed
wants to merge 1 commit into from

Conversation

@znewman01
Copy link
Contributor

znewman01 commented Nov 18, 2014

Fixes #4009.

Only lower-case the argument to Document#createElement if it's a HTML document.

Fixes #4009.

Only lower-case the argument to Document#createElement if it's a HTML document.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 18, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3208

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Nov 18, 2014

You should change the commit message to Only lower-case the argument to Document#createElement if it's a HTML document. or more suitable one.

@Ms2ger

This comment has been minimized.

Copy link

Ms2ger commented on a8ce3e3 Nov 18, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on a8ce3e3 Nov 18, 2014

saw approval from Ms2ger
at znewman01@a8ce3e3

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

merging znewman01/servo/issue4009 = a8ce3e3 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

znewman01/servo/issue4009 = a8ce3e3 merged ok, testing candidate = a65bf74

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

No active merge of candidate a8ce3e3 found, likely manual push to master

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

merging znewman01/servo/issue4009 = a8ce3e3 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

znewman01/servo/issue4009 = a8ce3e3 merged ok, testing candidate = 929671f

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

fast-forwarding master to auto = 929671f

bors-servo pushed a commit that referenced this pull request Nov 18, 2014
Fixes #4009.

Only lower-case the argument to Document#createElement if it's a HTML document.
bors-servo pushed a commit that referenced this pull request Nov 18, 2014
Fixes #4009.

Only lower-case the argument to Document#createElement if it's a HTML document.
@bors-servo bors-servo closed this Nov 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.