Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upStop including the element during Element.getElementsByClassName. #4030
Conversation
hoppipolla-critic-bot
commented
Nov 18, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3209 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
@achals: Thanks! I commented about one small nit on critic; please push an additional commit to fix that. |
|
@Ms2ger Thanks for the feedback, updated |
|
@achals: thank you! Please squash the two commits together so I can merge. |
|
@Ms2ger Squashed, can you please check if things look okay? |
This comment has been minimized.
This comment has been minimized.
Ms2ger
commented on 712b3d0
Nov 18, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Ms2ger |
This comment has been minimized.
This comment has been minimized.
|
merging achals/servo/master = 712b3d0 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 8cecb03 |
712b3d0
into
servo:master
achals commentedNov 18, 2014
#3995
This is my first PR, so please let me know if I'm doing something wrong!