Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop including the element during Element.getElementsByClassName. #4030

Merged
merged 1 commit into from Nov 18, 2014

Conversation

@achals
Copy link
Contributor

achals commented Nov 18, 2014

#3995

This is my first PR, so please let me know if I'm doing something wrong!

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 18, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3209

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 18, 2014

@achals: Thanks! I commented about one small nit on critic; please push an additional commit to fix that.

@achals
Copy link
Contributor Author

achals commented Nov 18, 2014

@Ms2ger Thanks for the feedback, updated

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 18, 2014

@achals: thank you! Please squash the two commits together so I can merge.

@achals achals force-pushed the achals:master branch from 843b7b5 to 712b3d0 Nov 18, 2014
@achals
Copy link
Contributor Author

achals commented Nov 18, 2014

@Ms2ger Squashed, can you please check if things look okay?

@Ms2ger

This comment has been minimized.

Copy link

Ms2ger commented on 712b3d0 Nov 18, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 712b3d0 Nov 18, 2014

saw approval from Ms2ger
at achals@712b3d0

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

merging achals/servo/master = 712b3d0 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

achals/servo/master = 712b3d0 merged ok, testing candidate = 8cecb03

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

fast-forwarding master to auto = 8cecb03

bors-servo pushed a commit that referenced this pull request Nov 18, 2014
#3995

This is my first PR, so please let me know if I'm doing something wrong!
@bors-servo bors-servo closed this Nov 18, 2014
@bors-servo bors-servo merged commit 712b3d0 into servo:master Nov 18, 2014
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.