Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upwide form buttons fixes #3972 #4031
Conversation
hoppipolla-critic-bot
commented
Nov 18, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3211 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
shrug I followed the prevailing style when writing the first input-related styles. |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging donaldpipowitch/servo/wide-form-buttons = 0339923 into auto |
This comment has been minimized.
This comment has been minimized.
|
donaldpipowitch/servo/wide-form-buttons = 0339923 merged ok, testing candidate = 79ddb191 |
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging donaldpipowitch/servo/wide-form-buttons = 0339923 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 51e1f56 |
|
Does "r+" trigger the bot? Can you help me read the error message correctly? Is this related to my commit?
|
|
Yes, it does; no, that's unrelated; the reason it didn't merge is an intermittent failure: we'll try again momentarily. |
0339923
into
servo:master
|
Thank you so much for the feedback. |
donaldpipowitch commentedNov 18, 2014
My first pull request to servo \o/
Try to fix #3972. Tested with
./mach run tests/html/test-inputs.html.Any reasons why this CSS is formatted this way? (All properties on the same line. Looks a little bit generated?)