Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wide form buttons fixes #3972 #4031

Merged
merged 1 commit into from Nov 18, 2014
Merged

wide form buttons fixes #3972 #4031

merged 1 commit into from Nov 18, 2014

Conversation

@donaldpipowitch
Copy link
Contributor

donaldpipowitch commented Nov 18, 2014

My first pull request to servo \o/

Try to fix #3972. Tested with ./mach run tests/html/test-inputs.html.
Any reasons why this CSS is formatted this way? (All properties on the same line. Looks a little bit generated?)

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 18, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3211

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member

jdm commented Nov 18, 2014

shrug I followed the prevailing style when writing the first input-related styles.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 0339923 Nov 18, 2014

saw approval from jdm
at donaldpipowitch@0339923

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

merging donaldpipowitch/servo/wide-form-buttons = 0339923 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

donaldpipowitch/servo/wide-form-buttons = 0339923 merged ok, testing candidate = 79ddb191

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

saw approval from jdm
at donaldpipowitch@0339923

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

merging donaldpipowitch/servo/wide-form-buttons = 0339923 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

donaldpipowitch/servo/wide-form-buttons = 0339923 merged ok, testing candidate = 51e1f56

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 18, 2014

fast-forwarding master to auto = 51e1f56

@donaldpipowitch
Copy link
Contributor Author

donaldpipowitch commented Nov 18, 2014

Does "r+" trigger the bot? Can you help me read the error message correctly? Is this related to my commit?

string_map.rs:57:24: 57:55 warning: use of deprecated item: Renamed to `get`, #[warn(deprecated)] on by default
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 18, 2014

Yes, it does; no, that's unrelated; the reason it didn't merge is an intermittent failure: we'll try again momentarily.

bors-servo pushed a commit that referenced this pull request Nov 18, 2014
My first pull request to servo \o/

Try to fix #3972. Tested with `./mach run tests/html/test-inputs.html`.
Any reasons why this CSS is formatted this way? (All properties on the same line. Looks a little bit _generated_?)
@bors-servo bors-servo closed this Nov 18, 2014
@bors-servo bors-servo merged commit 0339923 into servo:master Nov 18, 2014
1 check passed
1 check passed
default all tests passed
@donaldpipowitch
Copy link
Contributor Author

donaldpipowitch commented Nov 18, 2014

Thank you so much for the feedback.

@donaldpipowitch donaldpipowitch deleted the donaldpipowitch:wide-form-buttons branch Nov 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.