Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix build on mac gcc 4.2. #380 #404
Merged
+15
−41
Conversation
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
ecmascript test to return document title
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Implement IsEnabled Part of servo#13040 Not sure that the way I converted `GLboolean` to `bool` is correct <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/404) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
brson commentedApr 30, 2013
This adds clang detection to the Makefiles in skia and rust-azure and only adds
-Wno-c++11-extensionswhen building with clang. It also disables the check in mfbt that we are building with gcc 4.4 or greater so that building on mac with llvm-gcc 4.2 works.Depends on servo/rust-azure#14 and servo/skia#10
Fixes #380