Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded libbz2-dev to Debian based prerequisites #4042
Conversation
Encountered this when building for the first time today: ``` note: /usr/bin/ld: cannot find -lbz2 collect2: error: ld returned 1 exit status error: aborting due to previous error Could not compile `servo`. ``` Installing the libbz2-dev packaged fixed it.
hoppipolla-critic-bot
commented
Nov 19, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3222 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Any idea what we have that needs this? Seems very odd. |
|
From what I can tell after grepping my target directory, this seems to be from libfreetype2. A quick search reveals a few references to bzip2 over there. |
|
Yes, @SimonSapin had to get it installed on the build machines after the recent Skia build changes. |
|
@mttr, could you also add |
|
@SimonSapin Yes it was purely on accident, I didn't check the diff. |
|
@SimonSapin done! |
|
Thanks! |
This comment has been minimized.
This comment has been minimized.
SimonSapin
commented on 3b40b51
Nov 20, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from SimonSapin |
This comment has been minimized.
This comment has been minimized.
|
merging mttr/servo/debian_requirements_update = 3b40b51 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = df47124 |
…apin Encountered this when building for the first time today: ``` note: /usr/bin/ld: cannot find -lbz2 collect2: error: ld returned 1 exit status error: aborting due to previous error Could not compile `servo`. ``` Installing the libbz2-dev packaged fixed it. Added to the list of packages to install on Debian based linuxes in README.md
3b40b51
into
servo:master
mttr commentedNov 19, 2014
Encountered this when building for the first time today:
Installing the libbz2-dev packaged fixed it. Added to the list of packages to install on Debian based linuxes in README.md