Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added libbz2-dev to Debian based prerequisites #4042

Merged
merged 2 commits into from Nov 20, 2014

Conversation

@mttr
Copy link
Contributor

mttr commented Nov 19, 2014

Encountered this when building for the first time today:

note: /usr/bin/ld: cannot find -lbz2
collect2: error: ld returned 1 exit status

error: aborting due to previous error
Could not compile `servo`.

Installing the libbz2-dev packaged fixed it. Added to the list of packages to install on Debian based linuxes in README.md

Encountered this when building for the first time today:

```
note: /usr/bin/ld: cannot find -lbz2
collect2: error: ld returned 1 exit status

error: aborting due to previous error
Could not compile `servo`.
```

Installing the libbz2-dev packaged fixed it.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 19, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3222

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@metajack
Copy link
Contributor

metajack commented Nov 20, 2014

Any idea what we have that needs this? Seems very odd.

@mttr
Copy link
Contributor Author

mttr commented Nov 20, 2014

From what I can tell after grepping my target directory, this seems to be from libfreetype2. A quick search reveals a few references to bzip2 over there.

@jdm
Copy link
Member

jdm commented Nov 20, 2014

Yes, @SimonSapin had to get it installed on the build machines after the recent Skia build changes.

@SimonSapin
Copy link
Member

SimonSapin commented Nov 20, 2014

Sigh. This is a result of #3980 which did update the README, but then #3991 reverted that change (presumably accidentally).

@SimonSapin
Copy link
Member

SimonSapin commented Nov 20, 2014

@mttr, could you also add bzip2 in the corresponding lines for Fedora and Archlinux? See https://github.com/servo/servo/pull/3980/files#diff-1. Thanks!

@Hoverbear
Copy link
Member

Hoverbear commented Nov 20, 2014

@SimonSapin Yes it was purely on accident, I didn't check the diff.

@mttr
Copy link
Contributor Author

mttr commented Nov 20, 2014

@SimonSapin done!

@SimonSapin
Copy link
Member

SimonSapin commented Nov 20, 2014

Thanks!

@SimonSapin

This comment has been minimized.

Copy link

SimonSapin commented on 3b40b51 Nov 20, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 3b40b51 Nov 20, 2014

saw approval from SimonSapin
at mttr@3b40b51

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 20, 2014

merging mttr/servo/debian_requirements_update = 3b40b51 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 20, 2014

mttr/servo/debian_requirements_update = 3b40b51 merged ok, testing candidate = df47124

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 20, 2014

fast-forwarding master to auto = df47124

bors-servo pushed a commit that referenced this pull request Nov 20, 2014
…apin

Encountered this when building for the first time today:

```
note: /usr/bin/ld: cannot find -lbz2
collect2: error: ld returned 1 exit status

error: aborting due to previous error
Could not compile `servo`.
```

Installing the libbz2-dev packaged fixed it. Added to the list of packages to install on Debian based linuxes in README.md
@bors-servo bors-servo closed this Nov 20, 2014
@bors-servo bors-servo merged commit 3b40b51 into servo:master Nov 20, 2014
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.