Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Attr#nodeValue #4050

Merged
merged 2 commits into from Nov 21, 2014
Merged

Implements Attr#nodeValue #4050

merged 2 commits into from Nov 21, 2014

Conversation

@mttr
Copy link
Contributor

mttr commented Nov 20, 2014

Fixes #4047, and updates to expect tests that are now passing because of it.
mttr added 2 commits Nov 20, 2014
@mttr
Implement Attr#nodeValue
73721cd 
Fixes #4047
@mttr
Updated to expect tests that are now passing
Loading status checks…
a873911
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 20, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3231

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@Ms2ger

This comment has been minimized.

Sign in to view
Copy link

Ms2ger commented on a873911 Nov 21, 2014

r+
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 21, 2014

Looking good, thank you!
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on a873911 Nov 21, 2014

saw approval from Ms2ger
at mttr@a873911

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 21, 2014

merging mttr/servo/implement_attr_nodevalue = a873911 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 21, 2014

mttr/servo/implement_attr_nodevalue = a873911 merged ok, testing candidate = c23bfdf

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 21, 2014

all tests pass:
success: http://build.servo.org/builders/linux1/builds/24
success: http://build.servo.org/builders/linux2/builds/24
success: http://build.servo.org/builders/android/builds/91
success: http://build.servo.org/builders/mac1/builds/241
success: http://build.servo.org/builders/mac2/builds/241

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 21, 2014

fast-forwarding master to auto = c23bfdf
bors-servo pushed a commit that referenced this pull request Nov 21, 2014
bors-servo
auto merge of #4050 : mttr/servo/implement_attr_nodevalue, r=Ms2ger
Loading status checks…
c23bfdf 
Fixes #4047, and updates to expect tests that are now passing because of it.
@bors-servo bors-servo closed this Nov 21, 2014
@bors-servo bors-servo merged commit a873911 into servo:master Nov 21, 2014
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement Attr#nodeValue.
4 participants
@mttr @hoppipolla-critic-bot @Ms2ger @bors-servo
You can’t perform that action at this time.