Make set_timeout_or_interval's is_interval an enumerated value instead of a boolean

[trevorriles]

Created an IsInterval enum to improve readability and remove the need for true // is_interval

I'm still fairly new to rust. I briefly looked for a way to implement boolean comparisons of the enum but didn't figure out a way.

Also I'm not attached to any of the names. Let me know what I can fix :)

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/3244

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[trevorriles]

Fixes #4059

[jdm]

r+, Thanks!

[larsbergstrom]

@bors: retry

[larsbergstrom]

@bors: retry

[jdm]

@bors: retry

[bors-servo]

saw approval from jdm
at trevorriles@0cba3ee

[bors-servo]

merging trevorriles/servo/isintervalenum = 0cba3ee into auto

[bors-servo]

trevorriles/servo/isintervalenum = 0cba3ee merged ok, testing candidate = 092357a

[bors-servo]

saw approval from jdm
at trevorriles@0cba3ee

[bors-servo]

merging trevorriles/servo/isintervalenum = 0cba3ee into auto

[bors-servo]

No active merge of candidate 0cba3ee found, likely manual push to master

[bors-servo]

merging trevorriles/servo/isintervalenum = 0cba3ee into auto

[bors-servo]

trevorriles/servo/isintervalenum = 0cba3ee merged ok, testing candidate = 90007ee

[bors-servo]

all tests pass:
success: http://build.servo.org/builders/linux1/builds/45
success: http://build.servo.org/builders/linux2/builds/45
success: http://build.servo.org/builders/android/builds/112
success: http://build.servo.org/builders/mac1/builds/262
success: http://build.servo.org/builders/mac2/builds/262

[bors-servo]

fast-forwarding master to auto = 90007ee

[larsbergstrom]

Attempting to close+reopen to see if that gets bors out of its confusion.

[trevorriles]

bors hates me :(

[larsbergstrom]

@trevorriles Did you set your author and user names when submitting your commit? I'm seeing an error about an unset username when buildbot attempts to perform some automated actions on your PR.

[jdm]

https://github.com/trevorriles/servo/commit/89f19499136ea6b83cf79e729d90d055568886e5.patch and https://github.com/trevorriles/servo/commit/0cba3eec626a5156508bda0cc7d518aba6a29323.patch look fine to me with respect to the author.

[trevorriles]

@larsbergstrom ahh didn't add that email to Github. If that is causing the issue, it should be better now.

[bors-servo]

saw approval from jdm
at trevorriles@0cba3ee

[bors-servo]

merging trevorriles/servo/isintervalenum = 0cba3ee into auto

[bors-servo]

trevorriles/servo/isintervalenum = 0cba3ee merged ok, testing candidate = 092357a

[bors-servo]

saw approval from jdm
at trevorriles@0cba3ee

[bors-servo]

merging trevorriles/servo/isintervalenum = 0cba3ee into auto

[bors-servo]

No active merge of candidate 0cba3ee found, likely manual push to master

[bors-servo]

merging trevorriles/servo/isintervalenum = 0cba3ee into auto

[bors-servo]

trevorriles/servo/isintervalenum = 0cba3ee merged ok, testing candidate = 90007ee

[bors-servo]

all tests pass:
success: http://build.servo.org/builders/linux1/builds/45
success: http://build.servo.org/builders/linux2/builds/45
success: http://build.servo.org/builders/android/builds/112
success: http://build.servo.org/builders/mac1/builds/262
success: http://build.servo.org/builders/mac2/builds/262

[bors-servo]

fast-forwarding master to auto = 90007ee

[metajack]

Instead of closing and reopening you can redeliver the notification to Bors from the webhook admin panel.

[jdm]

Closing to allow other PRs to proceed at this point.