New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper #4065

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
5 participants
@seanmonstar
Contributor

seanmonstar commented Nov 22, 2014

Replaces rust-http with hyper.

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956

Review on Reviewable

@seanmonstar seanmonstar reopened this Nov 22, 2014

@hoppipolla-critic-bot

This comment has been minimized.

Show comment
Hide comment
@hoppipolla-critic-bot

hoppipolla-critic-bot Nov 22, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3246

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

Critic review: https://critic.hoppipolla.co.uk/r/3246

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Manishearth Manishearth referenced this pull request Nov 22, 2014

Closed

Cookie storage design #3389

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Nov 28, 2014

Member

@seanmonstar This needs a rebase, #4128 probably broke it. Feel free to squash commits if you want, and ping me for the r+ :)

Member

Manishearth commented Nov 28, 2014

@seanmonstar This needs a rebase, #4128 probably broke it. Feel free to squash commits if you want, and ping me for the r+ :)

@jdm jdm added the S-needs-rebase label Nov 28, 2014

@seanmonstar

This comment has been minimized.

Show comment
Hide comment
@seanmonstar

seanmonstar Nov 28, 2014

Contributor

@Manishearth i rebased against master... it seemed to fix 2 more tests, regarding network-errors (related to status_code=0?). But I'm also getting some crashes. The crashes also occur when I check out master, so I'm not sure my code introduced them...

Contributor

seanmonstar commented Nov 28, 2014

@Manishearth i rebased against master... it seemed to fix 2 more tests, regarding network-errors (related to status_code=0?). But I'm also getting some crashes. The crashes also occur when I check out master, so I'm not sure my code introduced them...

bors-servo pushed a commit that referenced this pull request Nov 29, 2014

bors-servo
auto merge of #4065 : seanmonstar/servo/hyper, r=Manishearth
Replaces `rust-http` with [hyper](https://github.com/hyperium/hyper).

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956

bors-servo pushed a commit that referenced this pull request Nov 29, 2014

bors-servo
auto merge of #4065 : seanmonstar/servo/hyper, r=Manishearth
Replaces `rust-http` with [hyper](https://github.com/hyperium/hyper).

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956

bors-servo pushed a commit that referenced this pull request Nov 29, 2014

bors-servo
auto merge of #4065 : seanmonstar/servo/hyper, r=Manishearth
Replaces `rust-http` with [hyper](https://github.com/hyperium/hyper).

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956

bors-servo pushed a commit that referenced this pull request Nov 29, 2014

bors-servo
auto merge of #4065 : seanmonstar/servo/hyper, r=Manishearth
Replaces `rust-http` with [hyper](https://github.com/hyperium/hyper).

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956
@seanmonstar

This comment has been minimized.

Show comment
Hide comment
@seanmonstar

seanmonstar Nov 29, 2014

Contributor

Ok, I adjusted the lockfiles in port to pull in the same version of cookies and move-acceptor, which removed the dep on time, and the missing_doc warning, respectively.

Contributor

seanmonstar commented Nov 29, 2014

Ok, I adjusted the lockfiles in port to pull in the same version of cookies and move-acceptor, which removed the dep on time, and the missing_doc warning, respectively.

@jdm jdm removed the S-tests-failed label Nov 29, 2014

bors-servo pushed a commit that referenced this pull request Nov 29, 2014

bors-servo
auto merge of #4065 : seanmonstar/servo/hyper, r=jdm
Replaces `rust-http` with [hyper](https://github.com/hyperium/hyper).

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956
@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Nov 30, 2014

Member

Android build failure:

note: /home/servo/ndk-toolchain/bin/../lib/gcc/arm-linux-androideabi/4.6/../../../../arm-linux-androideabi/bin/ld: error: cannot find -lssl
/home/servo/ndk-toolchain/bin/../lib/gcc/arm-linux-androideabi/4.6/../../../../arm-linux-androideabi/bin/ld: error: cannot find -lcrypto
Member

jdm commented Nov 30, 2014

Android build failure:

note: /home/servo/ndk-toolchain/bin/../lib/gcc/arm-linux-androideabi/4.6/../../../../arm-linux-androideabi/bin/ld: error: cannot find -lssl
/home/servo/ndk-toolchain/bin/../lib/gcc/arm-linux-androideabi/4.6/../../../../arm-linux-androideabi/bin/ld: error: cannot find -lcrypto

bors-servo pushed a commit that referenced this pull request Nov 30, 2014

bors-servo
auto merge of #4065 : seanmonstar/servo/hyper, r=Manishearth
Replaces `rust-http` with [hyper](https://github.com/hyperium/hyper).

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956

bors-servo pushed a commit that referenced this pull request Nov 30, 2014

bors-servo
auto merge of #4065 : seanmonstar/servo/hyper, r=Manishearth
Replaces `rust-http` with [hyper](https://github.com/hyperium/hyper).

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956

bors-servo pushed a commit that referenced this pull request Nov 30, 2014

bors-servo
auto merge of #4065 : seanmonstar/servo/hyper, r=Manishearth
Replaces `rust-http` with [hyper](https://github.com/hyperium/hyper).

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956

bors-servo pushed a commit that referenced this pull request Nov 30, 2014

bors-servo
auto merge of #4065 : seanmonstar/servo/hyper, r=Manishearth
Replaces `rust-http` with [hyper](https://github.com/hyperium/hyper).

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956

bors-servo pushed a commit that referenced this pull request Nov 30, 2014

bors-servo
auto merge of #4065 : seanmonstar/servo/hyper, r=Manishearth
Replaces `rust-http` with [hyper](https://github.com/hyperium/hyper).

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956

bors-servo pushed a commit that referenced this pull request Nov 30, 2014

bors-servo
auto merge of #4065 : seanmonstar/servo/hyper, r=Manishearth
Replaces `rust-http` with [hyper](https://github.com/hyperium/hyper).

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956

bors-servo pushed a commit that referenced this pull request Nov 30, 2014

bors-servo
auto merge of #4065 : seanmonstar/servo/hyper, r=Manishearth
Replaces `rust-http` with [hyper](https://github.com/hyperium/hyper).

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956

bors-servo pushed a commit that referenced this pull request Nov 30, 2014

bors-servo
auto merge of #4065 : seanmonstar/servo/hyper, r=Manishearth
Replaces `rust-http` with [hyper](https://github.com/hyperium/hyper).

I don't have any bench numbers: I'm not sure what I would run (before and after) to make a nice presentation. If someone could help me there, I can update this description.

WPT-wise, ~18 more tests succeeding.

So say we all?

Closes #3956

@jdm jdm added the S-tests-failed label Nov 30, 2014

bors-servo pushed a commit that referenced this pull request Dec 4, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
This is the Hyper pull request, plus the set up for OpenSSL on Android to make it merge.

Sean's commits have been reviewed in #4065

bors-servo pushed a commit that referenced this pull request Dec 5, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
This is the Hyper pull request, plus the set up for OpenSSL on Android to make it merge.

Sean's commits have been reviewed in #4065

bors-servo pushed a commit that referenced this pull request Dec 5, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
This is the Hyper pull request, plus the set up for OpenSSL on Android to make it merge.

Sean's commits have been reviewed in #4065

bors-servo pushed a commit that referenced this pull request Dec 5, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
This is the Hyper pull request, plus the set up for OpenSSL on Android to make it merge.

Sean's commits have been reviewed in #4065

bors-servo pushed a commit that referenced this pull request Dec 5, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
This is the Hyper pull request, plus the set up for OpenSSL on Android to make it merge.

Sean's commits have been reviewed in #4065 (My Android changes were reviewed by Glenn)
@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Dec 5, 2014

Member

Merged via #4198

Member

Manishearth commented Dec 5, 2014

Merged via #4198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment