Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Document#createAttribute #4067

Merged
merged 1 commit into from Nov 23, 2014
Merged

implement Document#createAttribute #4067

merged 1 commit into from Nov 23, 2014

Conversation

@ajnirp
Copy link
Contributor

ajnirp commented Nov 22, 2014

fixes #4054
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 22, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3247

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@ajnirp
implement Document#createAttribute
Loading status checks…
4b754bd
@ajnirp ajnirp force-pushed the ajnirp:document-create-attribute branch from 11ecfde to 4b754bd Nov 23, 2014
@Manishearth

This comment has been minimized.

Sign in to view
Copy link

Manishearth commented on 4b754bd Nov 23, 2014

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 4b754bd Nov 23, 2014

saw approval from Manishearth
at ajnirp@4b754bd

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 23, 2014

merging wenderen/servo/document-create-attribute = 4b754bd into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 23, 2014

wenderen/servo/document-create-attribute = 4b754bd merged ok, testing candidate = d215ff7

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 23, 2014

all tests pass:
success: http://build.servo.org/builders/linux1/builds/32
success: http://build.servo.org/builders/linux2/builds/32
success: http://build.servo.org/builders/android/builds/99
success: http://build.servo.org/builders/mac1/builds/249
success: http://build.servo.org/builders/mac2/builds/249

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 23, 2014

fast-forwarding master to auto = d215ff7
bors-servo pushed a commit that referenced this pull request Nov 23, 2014
bors-servo
auto merge of #4067 : wenderen/servo/document-create-attribute, r=Man…
Loading status checks…
d215ff7 
…ishearth

fixes #4054
@bors-servo bors-servo closed this Nov 23, 2014
@bors-servo bors-servo merged commit 4b754bd into servo:master Nov 23, 2014
1 check passed
1 check passed
default all tests passed
@ajnirp ajnirp deleted the ajnirp:document-create-attribute branch Nov 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement Document#createAttribute.
4 participants
@ajnirp @hoppipolla-critic-bot @bors-servo @Manishearth
You can’t perform that action at this time.