Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse atom! in place of Atom::from_slice where necessary #4068
Conversation
hoppipolla-critic-bot
commented
Nov 22, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3248 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
For shame! |
|
Heh, I was unable to test this due to a broken green-rs. Will fix :) |
This comment has been minimized.
This comment has been minimized.
|
r=jdm |
This comment has been minimized.
This comment has been minimized.
jdm
replied
Nov 23, 2014
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
jdm
replied
Nov 24, 2014
|
@bors: retry |
|
(still can't test, build 2 broken and build 1 is doing activation stuff. But this should be the only unused import) |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging Manishearth/servo/atomify = 5349193 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging Manishearth/servo/atomify = 5349193 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 60dfb65 |
5349193
into
servo:master
Manishearth commentedNov 22, 2014
No description provided.