Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use atom! in place of Atom::from_slice where necessary #4068

Merged
merged 1 commit into from Nov 24, 2014

Conversation

@Manishearth
Copy link
Member

Manishearth commented Nov 22, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 22, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3248

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

bors-servo pushed a commit that referenced this pull request Nov 23, 2014
@jdm
Copy link
Member

jdm commented Nov 23, 2014

dom/htmlserializer.rs:21:5: 21:23 error: unused import
dom/htmlserializer.rs:21 use string_cache::Atom;

For shame!

@Manishearth
Copy link
Member Author

Manishearth commented Nov 23, 2014

Heh, I was unable to test this due to a broken green-rs. Will fix :)

@Manishearth Manishearth force-pushed the Manishearth:atomify branch from dfa0b7e to 5349193 Nov 23, 2014
@Manishearth

This comment has been minimized.

Copy link
Owner Author

Manishearth commented on 5349193 Nov 23, 2014

r=jdm

This comment has been minimized.

Copy link

jdm replied Nov 23, 2014

@bors: retry

This comment has been minimized.

Copy link
Owner Author

Manishearth replied Nov 23, 2014

@bors: retry

This comment has been minimized.

Copy link
Owner Author

Manishearth replied Nov 23, 2014

@bors: retry

This comment has been minimized.

Copy link

jdm replied Nov 24, 2014

@bors: retry

@Manishearth
Copy link
Member Author

Manishearth commented Nov 23, 2014

(still can't test, build 2 broken and build 1 is doing activation stuff. But this should be the only unused import)

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 5349193 Nov 23, 2014

saw approval from jdm
at Manishearth@5349193

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 23, 2014

merging Manishearth/servo/atomify = 5349193 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 23, 2014

Manishearth/servo/atomify = 5349193 merged ok, testing candidate = d48b05d

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 23, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 23, 2014

saw approval from jdm
at Manishearth@5349193

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 24, 2014

saw approval from jdm
at Manishearth@5349193

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 24, 2014

merging Manishearth/servo/atomify = 5349193 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 24, 2014

Manishearth/servo/atomify = 5349193 merged ok, testing candidate = 60dfb65

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 24, 2014

fast-forwarding master to auto = 60dfb65

bors-servo pushed a commit that referenced this pull request Nov 23, 2014
bors-servo pushed a commit that referenced this pull request Nov 23, 2014
bors-servo pushed a commit that referenced this pull request Nov 23, 2014
bors-servo pushed a commit that referenced this pull request Nov 23, 2014
bors-servo pushed a commit that referenced this pull request Nov 24, 2014
@bors-servo bors-servo closed this Nov 24, 2014
@bors-servo bors-servo merged commit 5349193 into servo:master Nov 24, 2014
1 check passed
1 check passed
default all tests passed
@Manishearth Manishearth deleted the Manishearth:atomify branch Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.