Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove PseudoDisplayItemClass #4073
Conversation
hoppipolla-critic-bot
commented
Nov 22, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3252 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Now that content box queries are made against the flow tree, we can remove PseudoDisplayItems from the display list.
|
Interestingly, both mac and linux reftests failed with |
|
So after a lot of false starts I was finally able to track the test failure down to a bug in how we specify the clipping region during display list rasterization. Previously clips were applied before the transformation matrix, which is problem for positioned children and non-origin tiles. Removing PseudoDisplayListItem merely uncovered this bug. |
Now that content box queries are made against the flow tree, we can remove PseudoDisplayItems from the display list.
This comment has been minimized.
This comment has been minimized.
pcwalton
commented on 2e8f1c0
Dec 10, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from pcwalton |
This comment has been minimized.
This comment has been minimized.
|
merging mrobinson/servo/pseudo-rm-rf = 2e8f1c0 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = d988d01 |
Now that content box queries are made against the flow tree, we can remove PseudoDisplayItems from the display list.
mrobinson commentedNov 22, 2014
Now that content box queries are made against the flow tree, we can
remove PseudoDisplayItems from the display list.