Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PseudoDisplayItemClass #4073

Closed
wants to merge 1 commit into from
Closed

Conversation

@mrobinson
Copy link
Member

mrobinson commented Nov 22, 2014

Now that content box queries are made against the flow tree, we can
remove PseudoDisplayItems from the display list.

Review on Reviewable

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 22, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3252

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

bors-servo pushed a commit that referenced this pull request Nov 23, 2014
Now that content box queries are made against the flow tree, we can
remove PseudoDisplayItems from the display list.
@jdm
Copy link
Member

jdm commented Nov 23, 2014

Interestingly, both mac and linux reftests failed with background_repeat_x_a.html == background_repeat_x_b.html.

@mrobinson
Copy link
Member Author

mrobinson commented Dec 1, 2014

So after a lot of false starts I was finally able to track the test failure down to a bug in how we specify the clipping region during display list rasterization. Previously clips were applied before the transformation matrix, which is problem for positioned children and non-origin tiles. Removing PseudoDisplayListItem merely uncovered this bug.

Now that content box queries are made against the flow tree, we can
remove PseudoDisplayItems from the display list.
@mrobinson mrobinson force-pushed the mrobinson:pseudo-rm-rf branch from e7956c7 to 2e8f1c0 Dec 10, 2014
@mrobinson mrobinson closed this Dec 10, 2014
@mrobinson mrobinson reopened this Dec 10, 2014
@pcwalton

This comment has been minimized.

Copy link

pcwalton commented on 2e8f1c0 Dec 10, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 2e8f1c0 Dec 10, 2014

saw approval from pcwalton
at mrobinson@2e8f1c0

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 10, 2014

merging mrobinson/servo/pseudo-rm-rf = 2e8f1c0 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 10, 2014

mrobinson/servo/pseudo-rm-rf = 2e8f1c0 merged ok, testing candidate = d988d01

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 10, 2014

fast-forwarding master to auto = d988d01

bors-servo pushed a commit that referenced this pull request Dec 10, 2014
Now that content box queries are made against the flow tree, we can
remove PseudoDisplayItems from the display list.
@bors-servo bors-servo closed this Dec 10, 2014
@mrobinson mrobinson deleted the mrobinson:pseudo-rm-rf branch Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.