Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-layers to fix empty BufferRequest failures #4074

Merged
merged 1 commit into from Nov 23, 2014

Conversation

@mrobinson
Copy link
Member

mrobinson commented Nov 23, 2014

rust-layers will now avoid sending empty buffer requests which can
cause failures when Servo tries to create empty platform surfaces.

Fixes #4060.

rust-layers will now avoid sending empty buffer requests which can
cause failures when Servo tries to create empty platform surfaces.

Fixes #4060.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 23, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3254

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm

This comment has been minimized.

Copy link

jdm commented on 737a146 Nov 23, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 737a146 Nov 23, 2014

saw approval from jdm
at mrobinson@737a146

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 23, 2014

merging mrobinson/servo/empty-tiles = 737a146 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 23, 2014

mrobinson/servo/empty-tiles = 737a146 merged ok, testing candidate = b33c31b

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 23, 2014

fast-forwarding master to auto = b33c31b

bors-servo pushed a commit that referenced this pull request Nov 23, 2014
rust-layers will now avoid sending empty buffer requests which can
cause failures when Servo tries to create empty platform surfaces.

Fixes #4060.
@bors-servo bors-servo closed this Nov 23, 2014
@bors-servo bors-servo merged commit 737a146 into servo:master Nov 23, 2014
1 check passed
1 check passed
default all tests passed
@mrobinson mrobinson deleted the mrobinson:empty-tiles branch Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.