Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate rust-layers to fix empty BufferRequest failures #4074
Conversation
hoppipolla-critic-bot
commented
Nov 23, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3254 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
jdm
commented on 737a146
Nov 23, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging mrobinson/servo/empty-tiles = 737a146 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = b33c31b |
737a146
into
servo:master
mrobinson commentedNov 23, 2014
rust-layers will now avoid sending empty buffer requests which can
cause failures when Servo tries to create empty platform surfaces.
Fixes #4060.