Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement HTML{Anchor,Area,Link}Element.relList. #4081
Conversation
hoppipolla-critic-bot
commented
Nov 24, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3263 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
reviewed. @jdm: do you have any points? |
|
Yep, just a couple duplication/correctness things. |
|
Thanks for the feedback, updated. |
|
reviewed. please squashed. there would be no points. |
|
Thanks, done. |
This comment has been minimized.
This comment has been minimized.
jdm
commented on 23ed1f7
Nov 24, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging achals/servo/master = 23ed1f7 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 6e19955 |
achals commentedNov 24, 2014
#3994