Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTML{Anchor,Area,Link}Element.relList. #4081

Closed
wants to merge 1 commit into from

Conversation

@achals
Copy link
Contributor

achals commented Nov 24, 2014

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 24, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3263

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Nov 24, 2014

reviewed.

@jdm: do you have any points?

@jdm
Copy link
Member

jdm commented Nov 24, 2014

Yep, just a couple duplication/correctness things.

@achals
Copy link
Contributor Author

achals commented Nov 24, 2014

Thanks for the feedback, updated.

@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Nov 24, 2014

reviewed. please squashed. there would be no points.

@achals achals force-pushed the achals:master branch from 7196f72 to 23ed1f7 Nov 24, 2014
@achals
Copy link
Contributor Author

achals commented Nov 24, 2014

Thanks, done.

@jdm

This comment has been minimized.

Copy link

jdm commented on 23ed1f7 Nov 24, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 23ed1f7 Nov 24, 2014

saw approval from jdm
at achals@23ed1f7

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 24, 2014

merging achals/servo/master = 23ed1f7 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 24, 2014

achals/servo/master = 23ed1f7 merged ok, testing candidate = 6e19955

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 24, 2014

fast-forwarding master to auto = 6e19955

bors-servo pushed a commit that referenced this pull request Nov 24, 2014
@bors-servo bors-servo closed this Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.