Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds explicit --name argument to test-ref #4093
Conversation
In addition, `./mach test` will now take advantage of this when inferring test suites from test files.
hoppipolla-critic-bot
commented
Nov 25, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3277 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
jdm
commented on 27a9460
Nov 29, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging mttr/servo/mach_reftest_by_file = 27a9460 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = b87d98e |
`./mach test-ref` no longer eats the first "-" prefixed argument for test name filtering, instead using an explicit "--name" argument. This should avoid any potential confusion when passing down arguments to servo. Also allows for ./tests/ref to be included (and trimmed away) for tab completion convenience (`./mach test` has also been updated to take advantage of this when inferring tests from file paths). (fixes #4091)
bors-servo
merged commit 27a9460
into
servo:master
mttr commentedNov 25, 2014
./mach test-refno longer eats the first "-" prefixed argument for test name filtering, instead using an explicit "--name" argument. This should avoid any potential confusion when passing down arguments to servo.Also allows for ./tests/ref to be included (and trimmed away) for tab completion convenience (
./mach testhas also been updated to take advantage of this when inferring tests from file paths).(fixes #4091)