Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout on google search results. #4114

Merged
merged 1 commit into from Nov 27, 2014
Merged

Conversation

@glennw
Copy link
Member

glennw commented Nov 26, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 26, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3293

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@glennw
Copy link
Member Author

glennw commented Nov 26, 2014

@pcwalton

This comment has been minimized.

Copy link
Contributor

pcwalton commented on 59cdce3 Nov 27, 2014

r+

Nice catch, I bet this improves other sites too.

This comment has been minimized.

Copy link
Member

glennw replied Nov 27, 2014

r=pcwalton

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 27, 2014

saw approval from pcwalton
at glennw@59cdce3

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 27, 2014

merging glennw/servo/table-layout-fix = 59cdce3 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 27, 2014

glennw/servo/table-layout-fix = 59cdce3 merged ok, testing candidate = 431644b

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 27, 2014

fast-forwarding master to auto = 431644b

@pcwalton

This comment has been minimized.

Copy link
Contributor

pcwalton commented on 59cdce3 Nov 27, 2014

r+

Nice catch, I bet this improves other sites too.

This comment has been minimized.

Copy link
Member

glennw replied Nov 27, 2014

r=pcwalton

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 27, 2014

saw approval from pcwalton
at glennw@59cdce3

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 27, 2014

merging glennw/servo/table-layout-fix = 59cdce3 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 27, 2014

glennw/servo/table-layout-fix = 59cdce3 merged ok, testing candidate = 431644b

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 27, 2014

fast-forwarding master to auto = 431644b

@metajack

This comment has been minimized.

Copy link

metajack commented on 59cdce3 Nov 27, 2014

r=pcwalton

bors-servo pushed a commit that referenced this pull request Nov 27, 2014
@bors-servo bors-servo closed this Nov 27, 2014
@bors-servo bors-servo merged commit 59cdce3 into servo:master Nov 27, 2014
1 check passed
1 check passed
default all tests passed
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 27, 2014

@glennw, can I have a pointer to the spec that backs this up, please?

@glennw glennw deleted the glennw:table-layout-fix branch Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.