Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #4120 #4129

Closed
wants to merge 1 commit into from
Closed

Fixes issue #4120 #4129

wants to merge 1 commit into from

Conversation

@aakashjain
Copy link
Contributor

aakashjain commented Nov 27, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 27, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3306

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@jdm
Copy link
Member

jdm commented Nov 27, 2014

@saneyuki Want to review this one?
@aakashjain aakashjain changed the title Fixes issue #4120 Fixes issue servo/servo#4120 Nov 28, 2014
@aakashjain aakashjain changed the title Fixes issue servo/servo#4120 Fixes issue #4120 Nov 28, 2014
@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Nov 28, 2014

relate: #4120
@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Nov 28, 2014

reviewed on Critic.
@aakashjain
Implemented hidden, removed corresponding passed tests
Loading status checks…
5a30bd0
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 5a30bd0 Nov 28, 2014

saw approval from Manishearth
at aakashjain@5a30bd0

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 28, 2014

merging aakashjain/servo/HTMLElement#hidden = 5a30bd0 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 28, 2014

aakashjain/servo/HTMLElement#hidden = 5a30bd0 merged ok, testing candidate = 12ae541

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 28, 2014

all tests pass:
success: http://build.servo.org/builders/linux1/builds/67
success: http://build.servo.org/builders/linux2/builds/67
success: http://build.servo.org/builders/android/builds/134
success: http://build.servo.org/builders/mac1/builds/284
success: http://build.servo.org/builders/mac2/builds/284

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 28, 2014

fast-forwarding master to auto = 12ae541
bors-servo pushed a commit that referenced this pull request Nov 28, 2014
bors-servo
auto merge of #4129 : aakashjain/servo/HTMLElement#hidden, r=Manishearth
Loading status checks…
12ae541
@bors-servo bors-servo closed this Nov 28, 2014
@tetsuharuohzeki tetsuharuohzeki mentioned this pull request Nov 28, 2014
Closed
@aakashjain aakashjain deleted the aakashjain:HTMLElement#hidden branch Nov 28, 2014
@aakashjain aakashjain restored the aakashjain:HTMLElement#hidden branch Nov 28, 2014
@aakashjain aakashjain deleted the aakashjain:HTMLElement#hidden branch Nov 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@aakashjain @hoppipolla-critic-bot @jdm @tetsuharuohzeki @bors-servo
You can’t perform that action at this time.