Implements basic form resetting #4133

mttr · 2014-11-28T00:48:59Z

We can reset <input type=text> fields! I wish I could've done something with checkboxes, but unfortunately, that's it for now.

In addition to that, this PR implements HTMLInputAttribute.defaultValue, updates wpt-test to expect passing tests as a result of that implementation, and fixes an index error crash with text inputs.

edit: also includes an html example where one may lazily watch form resets in action: tests/html/form_reset_handsfree.html

hoppipolla-critic-bot · 2014-11-28T00:49:05Z

Critic review: https://critic.hoppipolla.co.uk/r/3309

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

Manishearth · 2014-12-08T13:38:31Z

This looks good from my phone, I'll review this in detail soon.

mttr · 2014-12-08T19:48:40Z

Also implemented the :indeterminate pseudo-class while I was in there, which fixes #4079.

I may have broken critic, though..


        Fix crash in textinput


        Implements HTMLInputElement.defaultValue

...and changes SetValue to update the input text instead of the content attr. Also includes a comment summarizing everything I currently know with respect to an input elements checkedness vs its IDL attributes vs its content attributes.


        Implements basic form resetting

What can this do? Reset `<input type=text>` fields back to their default value through a call to a form's reset method. That's all for now! Fixes compile error after rebase


        Adds reset method to FormControl


        Implements FormControl for HTMLTextAreaElement


        Implements reset button


        htmltextarea: Fixed some value_changed issues

Also modified tests/html/textarea.html to allow for the testing of the textarea's dirty value flag.


        Implements DefaultChecked and resets of checkboxes


        Implements dirty value/checked flags for input

And modifies test-inputs.html to test. Fixes wpt breaking mistake


        Updated WPT to expect newly passing tests


        Implements :indeterminate pseudo-class

Addresses reviews

mttr · 2014-12-16T19:35:35Z

Rebased and squashed!

Manishearth · 2014-12-16T19:36:36Z

r+

bors-servo · 2014-12-16T19:39:47Z

saw approval from Manishearth
at mttr@504f968

bors-servo · 2014-12-16T19:39:48Z

merging mttr/servo/form_resetting = 504f968 into auto

bors-servo · 2014-12-16T19:39:48Z

mttr/servo/form_resetting = 504f968 merged ok, testing candidate = ae5699a

bors-servo · 2014-12-16T19:57:47Z

some tests failed:
failure: http://build.servo.org/builders/linux2/builds/324
failure: http://build.servo.org/builders/mac2/builds/542


        auto merge of #4133 : mttr/servo/form_resetting, r=Manishearth

We can reset `<input type=text>` fields! I wish I could've done something with checkboxes, but unfortunately, that's it for now. In addition to that, this PR implements `HTMLInputAttribute.defaultValue`, updates wpt-test to expect passing tests as a result of that implementation, and fixes an index error crash with text inputs. edit: also includes an html example where one may lazily watch form resets in action: ` tests/html/form_reset_handsfree.html`

jdm · 2014-12-16T20:42:46Z

/html/semantics/forms/the-input-element/password.html
-----------------------------------------------------
PASS expected FAIL Setting value changes the current value for password, but not the value content attribute
/html/semantics/forms/the-input-element/reset.html
--------------------------------------------------
PASS expected FAIL reset button only resets the form owner
PASS expected FAIL clicking on a disabled reset does nothing
PASS expected FAIL reset button associated with a form using the form attribute resets all the form's controls
/html/semantics/selectors/pseudo-classes/indeterminate.html
-----------------------------------------------------------
PASS expected FAIL adding a value to progress1 should put it in a determinate state


        Additional updates for newly passing WPT's

mttr · 2014-12-16T21:05:02Z

Got it.

jdm · 2014-12-16T22:01:19Z

r+

bors-servo · 2014-12-16T22:03:48Z

saw approval from jdm
at mttr@e496386

bors-servo · 2014-12-16T22:03:49Z

merging mttr/servo/form_resetting = e496386 into auto

bors-servo · 2014-12-16T22:03:49Z

mttr/servo/form_resetting = e496386 merged ok, testing candidate = 5951056

bors-servo · 2014-12-16T22:24:44Z

all tests pass:
success: http://build.servo.org/builders/linux1/builds/327
success: http://build.servo.org/builders/linux2/builds/326
success: http://build.servo.org/builders/android/builds/394
success: http://build.servo.org/builders/mac1/builds/543
success: http://build.servo.org/builders/mac2/builds/544

bors-servo · 2014-12-16T22:27:44Z

fast-forwarding master to auto = 5951056


        auto merge of #4133 : mttr/servo/form_resetting, r=jdm

We can reset `<input type=text>` fields! I wish I could've done something with checkboxes, but unfortunately, that's it for now. In addition to that, this PR implements `HTMLInputAttribute.defaultValue`, updates wpt-test to expect passing tests as a result of that implementation, and fixes an index error crash with text inputs. edit: also includes an html example where one may lazily watch form resets in action: ` tests/html/form_reset_handsfree.html`

jdm added the S-awaiting-review label Nov 28, 2014

mttr mentioned this pull request Dec 1, 2014

Remove force_relayout calls from HTMLInputElement attribute handler methods #3959

Closed

mttr force-pushed the mttr:form_resetting branch from 7906d7f to 5a99fe6 Dec 7, 2014

Manishearth self-assigned this Dec 8, 2014

mttr force-pushed the mttr:form_resetting branch from 6e32102 to 3871225 Dec 8, 2014

mttr added 2 commits Nov 27, 2014

Fix crash in textinput

f686943

Implements HTMLInputElement.defaultValue

f932a69

...and changes SetValue to update the input text instead of the content attr. Also includes a comment summarizing everything I currently know with respect to an input elements checkedness vs its IDL attributes vs its content attributes.

mttr force-pushed the mttr:form_resetting branch 2 times, most recently from 6379b8f to a425a39 Dec 16, 2014

mttr added 9 commits Nov 27, 2014

Implements basic form resetting

f0ce2af

What can this do? Reset `<input type=text>` fields back to their default value through a call to a form's reset method. That's all for now! Fixes compile error after rebase

Adds reset method to FormControl

a3b3295

Implements FormControl for HTMLTextAreaElement

7e0c39a

Implements reset button

4d0a6a6

htmltextarea: Fixed some value_changed issues

a5c0bb7

Also modified tests/html/textarea.html to allow for the testing of the textarea's dirty value flag.

Implements DefaultChecked and resets of checkboxes

38e4d86

Implements dirty value/checked flags for input

0c8e1ae

And modifies test-inputs.html to test. Fixes wpt breaking mistake

Updated WPT to expect newly passing tests

2d05ac5

Implements :indeterminate pseudo-class

Loading status checks…

504f968

Addresses reviews

mttr force-pushed the mttr:form_resetting branch from a425a39 to 504f968 Dec 16, 2014

jdm added S-tests-failed and removed S-awaiting-review labels Dec 16, 2014

Additional updates for newly passing WPT's

Loading status checks…

e496386

jdm added S-awaiting-merge and removed S-tests-failed labels Dec 16, 2014

bors-servo closed this Dec 16, 2014

bors-servo merged commit e496386 into servo:master Dec 16, 2014
1 check passed

1 check passed

default all tests passed

Manishearth mentioned this pull request Jan 10, 2015

Implement form resetting #3981

Closed

frewsxcv mentioned this pull request Dec 8, 2016

Implement form resetting #3555

Closed

servo / servo

Implements basic form resetting #4133

Implements basic form resetting #4133

mttr commented Nov 28, 2014

hoppipolla-critic-bot commented Nov 28, 2014

Manishearth commented Dec 8, 2014

mttr commented Dec 8, 2014

mttr commented Dec 16, 2014

This comment has been minimized.

Manishearth commented on `504f968` Dec 16, 2014

This comment has been minimized.

bors-servo commented on `504f968` Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

jdm commented Dec 16, 2014

mttr commented Dec 16, 2014

This comment has been minimized.

jdm commented on `e496386` Dec 16, 2014

This comment has been minimized.

bors-servo commented on `e496386` Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

servo / servo

Join GitHub today

Implements basic form resetting #4133

Implements basic form resetting #4133

Conversation

mttr commented Nov 28, 2014

hoppipolla-critic-bot commented Nov 28, 2014

Manishearth commented Dec 8, 2014

mttr commented Dec 8, 2014

mttr commented Dec 16, 2014

This comment has been minimized.

Manishearth commented on 504f968 Dec 16, 2014

This comment has been minimized.

bors-servo commented on 504f968 Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

jdm commented Dec 16, 2014

mttr commented Dec 16, 2014

This comment has been minimized.

jdm commented on e496386 Dec 16, 2014

This comment has been minimized.

bors-servo commented on e496386 Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

This comment has been minimized.

bors-servo replied Dec 16, 2014

Manishearth commented on `504f968` Dec 16, 2014

bors-servo commented on `504f968` Dec 16, 2014

jdm commented on `e496386` Dec 16, 2014

bors-servo commented on `e496386` Dec 16, 2014