Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when executing "mach doc" #4135

Closed
wants to merge 1 commit into from
Closed

Conversation

@murphm8
Copy link
Contributor

murphm8 commented Nov 28, 2014

This should fix #4134

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 28, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3310

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@mttr
Copy link
Contributor

mttr commented Nov 28, 2014

If you get rid of the "default=" altogether, it will pass through an empty list on its own. That's probably the best solution.

edit: Also check out the first python "gotcha" here. I don't think this would have broken anything in this case, but it's something to watch out for! :)

@murphm8 murphm8 force-pushed the murphm8:mach_doc branch from 90b0d9a to b4171b4 Nov 28, 2014
@murphm8
Copy link
Contributor Author

murphm8 commented Nov 28, 2014

Removed the default value.

@SimonSapin

This comment has been minimized.

Copy link

SimonSapin commented on b4171b4 Nov 28, 2014

r+

@SimonSapin
Copy link
Member

SimonSapin commented Nov 28, 2014

Thanks!

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on b4171b4 Nov 28, 2014

saw approval from SimonSapin
at murphm8@b4171b4

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 28, 2014

merging murphm8/servo/mach_doc = b4171b4 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 28, 2014

murphm8/servo/mach_doc = b4171b4 merged ok, testing candidate = fafd3fd

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 28, 2014

fast-forwarding master to auto = fafd3fd

bors-servo pushed a commit that referenced this pull request Nov 28, 2014
This should fix  #4134
@bors-servo bors-servo closed this Nov 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.