Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix error when executing "mach doc" #4135
Conversation
hoppipolla-critic-bot
commented
Nov 28, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3310 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
If you get rid of the "default=" altogether, it will pass through an empty list on its own. That's probably the best solution. edit: Also check out the first python "gotcha" here. I don't think this would have broken anything in this case, but it's something to watch out for! :) |
|
Removed the default value. |
This comment has been minimized.
This comment has been minimized.
SimonSapin
commented on b4171b4
Nov 28, 2014
|
r+ |
|
Thanks! |
This comment has been minimized.
This comment has been minimized.
|
saw approval from SimonSapin |
This comment has been minimized.
This comment has been minimized.
|
merging murphm8/servo/mach_doc = b4171b4 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = fafd3fd |
murphm8 commentedNov 28, 2014
This should fix #4134