Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that reftest passes valid servo args #4155

Closed
wants to merge 1 commit into from

Conversation

@mttr
Copy link
Contributor

mttr commented Nov 30, 2014

Fixes #4101

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 30, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3328

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm

This comment has been minimized.

Copy link

jdm commented on 41e50b0 Dec 2, 2014

r+

This comment has been minimized.

Copy link

jdm replied Dec 3, 2014

@bors: retry

@jdm jdm removed the S-awaiting-review label Dec 2, 2014
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 41e50b0 Dec 2, 2014

saw approval from jdm
at mttr@41e50b0

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 2, 2014

merging mttr/servo/reftest_unknown_servo_args = 41e50b0 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 2, 2014

mttr/servo/reftest_unknown_servo_args = 41e50b0 merged ok, testing candidate = 7badd93

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 2, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 3, 2014

saw approval from jdm
at mttr@41e50b0

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 3, 2014

merging mttr/servo/reftest_unknown_servo_args = 41e50b0 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 3, 2014

mttr/servo/reftest_unknown_servo_args = 41e50b0 merged ok, testing candidate = c682690

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 3, 2014

fast-forwarding master to auto = c682690

bors-servo pushed a commit that referenced this pull request Dec 2, 2014
bors-servo pushed a commit that referenced this pull request Dec 3, 2014
@bors-servo bors-servo closed this Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.