Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor flow #416

Merged
merged 12 commits into from May 7, 2013
Next

Fix style in `CharacterData`.

  • Loading branch information
pcwalton committed May 6, 2013
commit a178a7a5d182a0aba04d27315646f514a9a619f2
@@ -1,3 +1,9 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

//! DOM bindings for `CharacterData`.

use dom::bindings::utils::{DOMString, null_string, str};
use dom::node::{Node, NodeTypeId};

@@ -8,50 +14,51 @@ pub struct CharacterData {
data: DOMString
}

pub impl CharacterData {
fn new(id: NodeTypeId, data: ~str) -> CharacterData {
impl CharacterData {
pub fn new(id: NodeTypeId, data: ~str) -> CharacterData {
CharacterData {
parent: Node::new(id),
data: str(data)
}
}

fn GetData(&self) -> DOMString {
pub fn GetData(&self) -> DOMString {
copy self.data
}

fn SetData(&mut self, arg: DOMString) {
pub fn SetData(&mut self, arg: DOMString) {
self.data = arg;
}

fn Length(&self) -> u32 {
pub fn Length(&self) -> u32 {
match self.data {
str(ref s) => s.len() as u32,
null_string => 0
str(ref s) => s.len() as u32,
null_string => 0
}
}

fn SubstringData(&self, offset: u32, count: u32) -> DOMString {
pub fn SubstringData(&self, offset: u32, count: u32) -> DOMString {
match self.data {
str(ref s) => str(s.slice(offset as uint, count as uint).to_str()),
null_string => null_string
str(ref s) => str(s.slice(offset as uint, count as uint).to_str()),
null_string => null_string
}
}

fn AppendData(&mut self, arg: DOMString) {
pub fn AppendData(&mut self, arg: DOMString) {
let s = self.data.to_str();
self.data = str(str::append(s, arg.to_str()));
}

fn InsertData(&mut self, _offset: u32, _arg: DOMString) {
fail!(~"nyi")
pub fn InsertData(&mut self, _offset: u32, _arg: DOMString) {
fail!("CharacterData::InsertData() is unimplemented")
}

fn DeleteData(&mut self, _offset: u32, _count: u32) {
fail!(~"nyi")
pub fn DeleteData(&mut self, _offset: u32, _count: u32) {
fail!("CharacterData::DeleteData() is unimplemented")
}

fn ReplaceData(&mut self, _offset: u32, _count: u32, _arg: DOMString) {
fail!(~"nyi")
pub fn ReplaceData(&mut self, _offset: u32, _count: u32, _arg: DOMString) {
fail!("CharacterData::ReplaceData() is unimplemented")
}
}

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.