Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M1453: Review for GetCachedMessages #4175

Closed
wants to merge 9 commits into from

M1453: addressd review comments r/3291

  • Loading branch information
sam0rai9 committed Nov 28, 2014
commit 90f90c595091bd5870e690629a132906cc4a3cf2
@@ -116,7 +116,7 @@ impl Actor for NodeActor {
registry.actor_to_script(target.to_string()),
modifications));
let reply = ModifyAttributeReply{
from:self.name(),
from: self.name(),
};
stream.write_json_packet(&reply);
true
@@ -102,7 +102,7 @@ impl Actor for TabActor {
true
}

//FIXME: The current implemnetation won't work for multiple connections. Need to ensure
//FIXME: The current implementation won't work for multiple connections. Need to ensure
// that the correct stream is removed.
"detach" => {
let msg = TabDetachedReply {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.