New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper+OpenSSL on Android #4198

Merged
merged 6 commits into from Dec 5, 2014

Conversation

Projects
None yet
5 participants
@Manishearth
Member

Manishearth commented Dec 3, 2014

This is the Hyper pull request, plus the set up for OpenSSL on Android to make it merge.

Sean's commits have been reviewed in #4065 (My Android changes were reviewed by Glenn)

@hoppipolla-critic-bot

This comment has been minimized.

Show comment
Hide comment
@hoppipolla-critic-bot

hoppipolla-critic-bot Dec 3, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3358

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

Critic review: https://critic.hoppipolla.co.uk/r/3358

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

bors-servo pushed a commit that referenced this pull request Dec 3, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
Not to be merged, please back this out if it merges

bors-servo pushed a commit that referenced this pull request Dec 3, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
Not to be merged, please back this out if it merges

bors-servo pushed a commit that referenced this pull request Dec 3, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
Not to be merged, please back this out if it merges

bors-servo pushed a commit that referenced this pull request Dec 3, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
Not to be merged, please back this out if it merges

bors-servo pushed a commit that referenced this pull request Dec 3, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
Not to be merged, please back this out if it merges

bors-servo pushed a commit that referenced this pull request Dec 4, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
Not to be merged, please back this out if it merges

bors-servo pushed a commit that referenced this pull request Dec 4, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
Not to be merged, please back this out if it merges

@jdm jdm added the S-tests-failed label Dec 4, 2014

bors-servo pushed a commit that referenced this pull request Dec 4, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
Not to be merged, please back this out if it merges

bors-servo pushed a commit that referenced this pull request Dec 4, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
Not to be merged, please back this out if it merges

bors-servo pushed a commit that referenced this pull request Dec 4, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
Not to be merged, please back this out if it merges

bors-servo pushed a commit that referenced this pull request Dec 4, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
This is the Hyper pull request, plus the set up for OpenSSL on Android to make it merge.

Sean's commits have been reviewed in #4065

bors-servo pushed a commit that referenced this pull request Dec 5, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
This is the Hyper pull request, plus the set up for OpenSSL on Android to make it merge.

Sean's commits have been reviewed in #4065

bors-servo pushed a commit that referenced this pull request Dec 5, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
This is the Hyper pull request, plus the set up for OpenSSL on Android to make it merge.

Sean's commits have been reviewed in #4065
@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Dec 5, 2014

Owner

r=Manishearth,glennw

Owner

Manishearth commented on 00a0f15 Dec 5, 2014

r=Manishearth,glennw

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 5, 2014

Contributor

saw approval from Manishearth
at Manishearth@00a0f15

Contributor

bors-servo commented on 00a0f15 Dec 5, 2014

saw approval from Manishearth
at Manishearth@00a0f15

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 5, 2014

Contributor

merging Manishearth/servo/hyper-droid = 00a0f15 into auto

Contributor

bors-servo replied Dec 5, 2014

merging Manishearth/servo/hyper-droid = 00a0f15 into auto

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 5, 2014

Contributor

Manishearth/servo/hyper-droid = 00a0f15 merged ok, testing candidate = cc84fe0

Contributor

bors-servo replied Dec 5, 2014

Manishearth/servo/hyper-droid = 00a0f15 merged ok, testing candidate = cc84fe0

This comment has been minimized.

Show comment
Hide comment

bors-servo pushed a commit that referenced this pull request Dec 5, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
This is the Hyper pull request, plus the set up for OpenSSL on Android to make it merge.

Sean's commits have been reviewed in #4065
@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Dec 5, 2014

Owner

r=Manishearth,glennw

Owner

Manishearth commented on 642e766 Dec 5, 2014

r=Manishearth,glennw

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 5, 2014

Contributor

saw approval from Manishearth
at Manishearth@642e766

Contributor

bors-servo commented on 642e766 Dec 5, 2014

saw approval from Manishearth
at Manishearth@642e766

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 5, 2014

Contributor

merging Manishearth/servo/hyper-droid = 642e766 into auto

Contributor

bors-servo replied Dec 5, 2014

merging Manishearth/servo/hyper-droid = 642e766 into auto

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 5, 2014

Contributor

Manishearth/servo/hyper-droid = 642e766 merged ok, testing candidate = 6bd9bf9

Contributor

bors-servo replied Dec 5, 2014

Manishearth/servo/hyper-droid = 642e766 merged ok, testing candidate = 6bd9bf9

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 5, 2014

Contributor

fast-forwarding master to auto = 6bd9bf9

Contributor

bors-servo replied Dec 5, 2014

fast-forwarding master to auto = 6bd9bf9

bors-servo pushed a commit that referenced this pull request Dec 5, 2014

bors-servo
auto merge of #4198 : Manishearth/servo/hyper-droid, r=Manishearth
This is the Hyper pull request, plus the set up for OpenSSL on Android to make it merge.

Sean's commits have been reviewed in #4065 (My Android changes were reviewed by Glenn)

@bors-servo bors-servo closed this Dec 5, 2014

@bors-servo bors-servo merged commit 642e766 into servo:master Dec 5, 2014

1 check passed

default all tests passed

@Manishearth Manishearth referenced this pull request Dec 5, 2014

Closed

Hyper #4065

@Manishearth Manishearth deleted the Manishearth:hyper-droid branch Jan 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment