Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path for CEF build. #4207

Merged
merged 2 commits into from Dec 7, 2014
Merged

Fix path for CEF build. #4207

merged 2 commits into from Dec 7, 2014

Conversation

@glennw
Copy link
Member

glennw commented Dec 4, 2014

Review on Reviewable

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Dec 4, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3365

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@glennw
Copy link
Member Author

glennw commented Dec 4, 2014

bors-servo pushed a commit that referenced this pull request Dec 4, 2014
bors-servo pushed a commit that referenced this pull request Dec 4, 2014
@jdm jdm added the S-tests-failed label Dec 4, 2014
@glennw
Copy link
Member Author

glennw commented Dec 5, 2014

@SimonSapin any idea what may have caused these build failures? I'm guessing it's something to do with the changes to the target location / build directory, but I haven't looked into it yet.

@SimonSapin
Copy link
Member

SimonSapin commented Dec 5, 2014

I see three different errors in the logs.

Failed to run custom build command for `skia-sys v0.0.20130412 (https://github.com/servo/skia#79aa9354)`
Process didn't exit successfully: `make -f makefile.cargo -j4` (status=2)
--- stdout
[...]
--- stderr
src/core/SkAdvancedTypefaceMetrics.cpp:20:22: fatal error: ft2build.h: No such file or directory
 #include <ft2build.h>
                      ^

I don’t know what this is, but it looks probably not related to #4140.

./mach test-wpt --processes 4
[...]
Unexpected Results
==================

/html/semantics/forms/textfieldselection/selection.html
-------------------------------------------------------
CRASH [Parent]

Probably intermittent.

lib.rs:16:1: 16:21 error: can't find crate for `rustuv`
lib.rs:16 extern crate rustuv;
          ^~~~~~~~~~~~~~~~~~~~

rustuv was removed together with green in #4202. It doesn’t seem to be actually used, so I think you can just remove this extern crate line.

@glennw glennw force-pushed the glennw:fix-cef branch from df647b8 to ad9e76b Dec 7, 2014
@glennw
Copy link
Member Author

glennw commented Dec 7, 2014

@larsbergstrom

This comment has been minimized.

Copy link

larsbergstrom commented on ad9e76b Dec 7, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on ad9e76b Dec 7, 2014

saw approval from larsbergstrom
at glennw@ad9e76b

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 7, 2014

merging glennw/servo/fix-cef = ad9e76b into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 7, 2014

glennw/servo/fix-cef = ad9e76b merged ok, testing candidate = ccef723

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 7, 2014

fast-forwarding master to auto = ccef723

bors-servo pushed a commit that referenced this pull request Dec 7, 2014
@bors-servo bors-servo closed this Dec 7, 2014
@bors-servo bors-servo merged commit ad9e76b into servo:master Dec 7, 2014
1 check passed
1 check passed
default all tests passed
@glennw glennw deleted the glennw:fix-cef branch Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.