Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix path for CEF build. #4207
Fix path for CEF build. #4207
Conversation
hoppipolla-critic-bot
commented
Dec 4, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3365 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
r? @SimonSapin |
|
@SimonSapin any idea what may have caused these build failures? I'm guessing it's something to do with the changes to the target location / build directory, but I haven't looked into it yet. |
|
I see three different errors in the logs.
I don’t know what this is, but it looks probably not related to #4140.
Probably intermittent.
|
|
r? @metajack or @larsbergstrom ? |
This comment has been minimized.
This comment has been minimized.
larsbergstrom
commented on ad9e76b
Dec 7, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from larsbergstrom |
This comment has been minimized.
This comment has been minimized.
|
merging glennw/servo/fix-cef = ad9e76b into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = ccef723 |
ad9e76b
into
servo:master
glennw commentedDec 4, 2014