Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upM1456: Implement MIME Sniffing #4209
Conversation
|
Leaving all the commits...we can squash later. |
hoppipolla-critic-bot
commented
Dec 4, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3367 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
This has my blessing. Please rebase and squash! |
|
Squashed. |
|
Still needs a rebase. |
|
@jdm Looks like there is a bunch of net unit tests that are failing now. Some of them are simply because the fact that we will return a type for None...the system currently hangs instead of finishing the tests. These tests range from the data loader, to the image_cache_tasks, to the resource_tasks... This pull request is not ready for merge. |
|
Thanks for letting me know! |
|
@jdm It would appear to be due to the pass-through logic...something with the start call, I would guess with opening our own channels. Hopefully we can unwind this. |
|
Could you point out changes you've made in the most recent update? Furthermore, if there are additional changes forthcoming, can you make them in separate commits? |
|
@jdm Docs for demo: https://www.youtube.com/watch?v=ybX0hOkDJ8I&feature=youtu.be, The changes are all commits after 8af107c, but now we are passing unit tests but cannot load files...still not ready to merge :-/ |
|
Rebased in #5005. |
This rebases and integrates #4209, removing the sniffer task (turns out it wasn't a great idea), and adds a `--sniff-mime-types` command line flag to enable sniffing for file:// and http:// resources. Tested against a random picture file on my harddrive. The actual MIME sniffing implementation can be extracted into a separate library separately.
This rebases and integrates #4209, removing the sniffer task (turns out it wasn't a great idea), and adds a `--sniff-mime-types` command line flag to enable sniffing for file:// and http:// resources. Tested against a random picture file on my harddrive. The actual MIME sniffing implementation can be extracted into a separate library separately.
This rebases and integrates #4209, removing the sniffer task (turns out it wasn't a great idea), and adds a `--sniff-mime-types` command line flag to enable sniffing for file:// and http:// resources. Tested against a random picture file on my harddrive. The actual MIME sniffing implementation can be extracted into a separate library separately.
djzager commentedDec 4, 2014
Issue: #3144
Bring on the review!
To show mime-sniffing feature:
Open gif in servo.
./mach run tests/content/parsable_mime/image/gif/test87aCopy image outside of version control
cp tests/content/parsable_mime/image/gif/test87a ..Checkout changeset without feature.
git checkout 0d2251510fb9ad8f4974c99cadafbd1a9a81e30fAttempt to open gif in servo.
./mach run ../test87a