Bound several link properties.

[Zirak]

Specifically: href, rel, media, hreflang and type.

Fixes #4226.

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/3392

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[Zirak]

Note that the wpt tests for link.href are broken, since they rely on implementing several HTMLAnchorElement properties: https://github.com/servo/web-platform-tests/blob/servo/html/dom/reflection.js#L5-L36

It may be desirable to first fix those before merging this commit.

[Manishearth]

r+

[bors-servo]

saw approval from Manishearth
at Zirak@a61e869

[bors-servo]

merging Zirak/servo/link-attrs = a61e869 into auto

[bors-servo]

Zirak/servo/link-attrs = a61e869 merged ok, testing candidate = cbe93f7

[bors-servo]

some tests failed:
failure: http://build.servo.org/builders/linux2/builds/167
failure: http://build.servo.org/builders/mac1/builds/384

[Manishearth]

/html/dom/reflection-metadata.html
----------------------------------
PASS expected FAIL link.href: typeof IDL attribute
PASS expected FAIL link.href: IDL get with DOM attribute unset
PASS expected FAIL link.href: IDL set to "" followed by getAttribute()
PASS expected FAIL link.href: IDL set to " foo " followed by getAttribute()
PASS expected FAIL link.href: IDL set to "http://site.example/" followed by getAttribute()
PASS expected FAIL link.href: IDL set to "//site.example/path???@#l" followed by getAttribute()
PASS expected FAIL link.href: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by getAttribute()
PASS expected FAIL link.href: IDL set to undefined followed by getAttribute()
PASS expected FAIL link.href: IDL set to 7 followed by getAttribute()
PASS expected FAIL link.href: IDL set to 1.5 followed by getAttribute()
PASS expected FAIL link.href: IDL set to true followed by getAttribute()
PASS expected FAIL link.href: IDL set to false followed by getAttribute()
PASS expected FAIL link.href: IDL set to object "[object Object]" followed by getAttribute()
PASS expected FAIL link.href: IDL set to NaN followed by getAttribute()
PASS expected FAIL link.href: IDL set to Infinity followed by getAttribute()
PASS expected FAIL link.href: IDL set to -Infinity followed by getAttribute()
PASS expected FAIL link.href: IDL set to "\0" followed by getAttribute()
PASS expected FAIL link.href: IDL set to null followed by getAttribute()
PASS expected FAIL link.href: IDL set to object "test-toString" followed by getAttribute()

Could you just remove these entries from tests/wpt/metadata/html/dom/reflection-metadata.html.ini (amend+force push is fine)? Thanks!

[Zirak]

Oddly enough, after removing said tests locally, the build still fails, only now it didn't expect anything:

/html/dom/reflection-metadata.html
----------------------------------

FAIL link.href: setAttribute() to "" followed by IDL get
FAIL link.href: setAttribute() to " foo " followed by IDL get
FAIL link.href: setAttribute() to "http://site.example/" followed by IDL get
FAIL link.href: setAttribute() to "//site.example/path???@#l" followed by IDL get
FAIL link.href: setAttribute() to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get
FAIL link.href: setAttribute() to undefined followed by IDL get
FAIL link.href: setAttribute() to 7 followed by IDL get
FAIL link.href: setAttribute() to 1.5 followed by IDL get
FAIL link.href: setAttribute() to true followed by IDL get
FAIL link.href: setAttribute() to false followed by IDL get
FAIL link.href: setAttribute() to object "[object Object]" followed by IDL get
FAIL link.href: setAttribute() to NaN followed by IDL get
FAIL link.href: setAttribute() to Infinity followed by IDL get
FAIL link.href: setAttribute() to -Infinity followed by IDL get
FAIL link.href: setAttribute() to "\0" followed by IDL get
FAIL link.href: setAttribute() to null followed by IDL get
FAIL link.href: setAttribute() to object "test-toString" followed by IDL get
FAIL link.href: setAttribute() to object "test-valueOf" followed by IDL get
FAIL link.href: IDL set to "" followed by IDL get
FAIL link.href: IDL set to " foo " followed by IDL get
FAIL link.href: IDL set to "http://site.example/" followed by IDL get
FAIL link.href: IDL set to "//site.example/path???@#l" followed by IDL get
FAIL link.href: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get
FAIL link.href: IDL set to undefined followed by IDL get
FAIL link.href: IDL set to 7 followed by IDL get
FAIL link.href: IDL set to 1.5 followed by IDL get
FAIL link.href: IDL set to true followed by IDL get
FAIL link.href: IDL set to false followed by IDL get
FAIL link.href: IDL set to object "[object Object]" followed by IDL get
FAIL link.href: IDL set to NaN followed by IDL get
FAIL link.href: IDL set to Infinity followed by IDL get
FAIL link.href: IDL set to -Infinity followed by IDL get
FAIL link.href: IDL set to "\0" followed by IDL get
FAIL link.href: IDL set to null followed by IDL get
FAIL link.href: IDL set to object "test-toString" followed by IDL get
FAIL link.href: IDL set to object "test-valueOf" followed by IDL get

Note that this includes tests which for some reason "passed" before.

[Manishearth]

I'll poke at this with wptupdate and see what happens.

[Manishearth]

This seems to work for me. I'll open this in a separate PR since there's a chance the manifest fix went wrong somehow on your side. (My wptupdate was behaving a bit wonky too)

[Manishearth]

Moved to #4298

[Manishearth]

Woohoo, it merged! Thanks for the pull request!