Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement the "messageevent" argument to Document#createEvent. #4008 #4257
Conversation
hoppipolla-critic-bot
commented
Dec 5, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3397 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
jdm
commented on ccb4e8b
Dec 6, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
Thanks a lot!!! |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging johnathan79717/servo/4008 = ccb4e8b into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This will need to remove this expected failure from |
…rget-dispatchEvent.html.ini
|
@jdm |
This comment has been minimized.
This comment has been minimized.
Manishearth
commented on 8b8eea1
Dec 8, 2014
|
r=jdm |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging johnathan79717/servo/4008 = 8b8eea1 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = bdb3a25 |
8b8eea1
into
servo:master
johnathan79717 commentedDec 5, 2014
This is a fix for issue #4008.