Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the "messageevent" argument to Document#createEvent. #4008 #4257

Merged
merged 2 commits into from Dec 8, 2014

Conversation

@johnathan79717
Copy link
Contributor

johnathan79717 commented Dec 5, 2014

This is a fix for issue #4008.

Review on Reviewable

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Dec 5, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3397

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm

This comment has been minimized.

Copy link

jdm commented on ccb4e8b Dec 6, 2014

r+

This comment has been minimized.

Copy link
Owner Author

johnathan79717 replied Dec 6, 2014

Thanks a lot!!!

@jdm jdm removed the S-awaiting-review label Dec 6, 2014
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on ccb4e8b Dec 6, 2014

saw approval from jdm
at johnathan79717@ccb4e8b

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 6, 2014

merging johnathan79717/servo/4008 = ccb4e8b into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 6, 2014

johnathan79717/servo/4008 = ccb4e8b merged ok, testing candidate = bd92c88

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 6, 2014

bors-servo pushed a commit that referenced this pull request Dec 6, 2014
This is a fix for issue #4008.
@jdm
Copy link
Member

jdm commented Dec 6, 2014

/dom/events/EventTarget-dispatchEvent.html
------------------------------------------
PASS expected FAIL If the event's initialized flag is not set, an InvalidStateError must be thrown (MessageEvent).

This will need to remove this expected failure from tests/wpt/metadata/dom/events/EventTarget-dispatchEvent.html.ini.

…rget-dispatchEvent.html.ini
@johnathan79717
Copy link
Contributor Author

johnathan79717 commented Dec 8, 2014

@jdm
I have removed the expected failure as you suggested, thanks.

@Manishearth

This comment has been minimized.

Copy link

Manishearth commented on 8b8eea1 Dec 8, 2014

r=jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 8b8eea1 Dec 8, 2014

saw approval from jdm
at johnathan79717@8b8eea1

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 8, 2014

merging johnathan79717/servo/4008 = 8b8eea1 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 8, 2014

johnathan79717/servo/4008 = 8b8eea1 merged ok, testing candidate = bdb3a25

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 8, 2014

fast-forwarding master to auto = bdb3a25

bors-servo pushed a commit that referenced this pull request Dec 8, 2014
This is a fix for issue #4008.
@bors-servo bors-servo closed this Dec 8, 2014
@bors-servo bors-servo merged commit 8b8eea1 into servo:master Dec 8, 2014
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.