Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIncorrect license #427
Merged
Incorrect license #427
Conversation
|
r- remove swap file |
|
I don't see a swap file. Also, could you instead add the actual license? Just copy the one from here for example: |
|
oops. it contains additional 2 spaces ahead of line starts. |
Merged
mcepl
commented
Dec 13, 2013
|
I get this https://gist.github.com/mcepl/7944780 with c168e04 ... is the same problem or something else? |
|
Different problem, since it appears to be checking non-rust files for license headers. |
mcepl
commented
Dec 13, 2013
|
So, should I file a new bug or is known? |
|
Never heard of it before; please file a new one. |
mcepl
commented
Dec 13, 2013
|
It's #1402 |
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Add a test for the Comment constructor.
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Fixed a number of smoothstep() UB cases in the shaders Fixed the red rectangle in servo#427, but the text is still broken (to be addressed later). The change is similar to servo/webrender@b89ecd1, now all `smoothstep` calls should be correct. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/474) <!-- Reviewable:end -->
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Text transformation fixes Fixes servo#427 well, mostly... Looks like the transformed clips (servo#498) need to be implemented for this to work fully correct. Also adds a bit of comments to GLSL code to understand what's going on (please check if I misunderstood stuff and documented it wrong!). The errors spotted: 1. `layer.screen_vertices` was fetched with wrong indices 2. `untransform` would use undefined value of `t` if the layer plane is perpendicular to the view 3. text vertex shaders were missing a division by `vi.local_pos.z` for the layer coordinates 4. `prim.local_rect` was used for the text_run local rectangle, instead of `local_rect` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/497) <!-- Reviewable:end -->
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Local rectangle clipping for transformed primitives Finishes servo#427 implementation, now the text is cut evenly and not aligned to tile borders. Also refactored `build_bounding_rect()` as well as a bit of `assign_prims_to_screen_tiles()`.  <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/502) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
recrack commentedMay 9, 2013
i added ''xfail-license' comment.