Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBound several link properties. #4298
Merged
Conversation
Specifically: href, rel, media, hreflang and type.
This comment has been minimized.
This comment has been minimized.
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Manishearth |
This comment has been minimized.
This comment has been minimized.
|
merging Manishearth/servo/zirak-link-attrs = a586e05 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 7d4ec33 |
bors-servo
pushed a commit
that referenced
this pull request
Dec 9, 2014
Carried over from #4248 Critic review: https://critic.hoppipolla.co.uk/r/3392
bors-servo
merged commit a586e05
into
servo:master
1 check passed
1 check passed
default
all tests passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedDec 9, 2014
Carried over from #4248
Critic review: https://critic.hoppipolla.co.uk/r/3392