Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove various warnings #430

Merged
merged 2 commits into from May 10, 2013
Merged

Remove various warnings #430

merged 2 commits into from May 10, 2013
+3 −10

Conversation

@ILyoan
Copy link
Contributor

ILyoan commented May 9, 2013

No description provided.

@ILyoan
Copy link
Contributor Author

ILyoan commented May 10, 2013

Rebased.
r?
@metajack
Copy link
Contributor

metajack commented May 10, 2013

Looks good other than the note above.
ILyoan added 2 commits May 9, 2013
@ILyoan
Remove warnings from servo-gfx
17523bd
@ILyoan
Remove unused code
32d45bc
@ILyoan
Copy link
Contributor Author

ILyoan commented May 10, 2013

@metajack Thanks for comment.
Added a commit that removes unused codes r?
@metajack

This comment has been minimized.

Sign in to view
Copy link

metajack commented on 32d45bc May 10, 2013

Wow, I wasn't expecting this much fallout from that one line.

This looks to me like the code gets passed an old layer_buffer_set so that it can potentially reuse the buffers, but the current implementation does not do this. Is this your understanding as well?

I suspect this might have gotten changed when tiling support was added, and this is just vestigal code. @pcwalton thoughts?

This comment has been minimized.

Sign in to view
Copy link
Owner Author

ILyoan replied May 10, 2013

That's why I was reluctant to remove that line. There are commented out lines in that function that uses buffers. And It looks to me that it probably can be reused in the future.

This comment has been minimized.

Sign in to view
Copy link

pcwalton replied May 10, 2013

I'm fine with removing it. Eventually we would like to reuse buffers, but that isn't working right now.
metajack added a commit that referenced this pull request May 10, 2013
@metajack
Merge pull request #430 from ILyoan/rm_warning
077b481 
Remove various warnings
@metajack metajack merged commit 077b481 into servo:master May 10, 2013
@ILyoan ILyoan deleted the ILyoan:rm_warning branch May 14, 2013
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
@jgraham
Merge pull request servo#430 from foolip/crlf
29cfefd 
Convert CRLF line endings to LF in Opera tests
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
@bors-servo
Auto merge of servo#430 - servo:derive, r=Manishearth
3597a9d 
Switch to serde_derive

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/430)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@ILyoan @metajack @pcwalton
You can’t perform that action at this time.