Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor compositor #431
Merged
Refactor compositor #431
+515
−489
Conversation
|
Looks like you forgot to include the new compositing module. |
| } | ||
|
|
||
| /// Returns the size of the window. | ||
| pub fn size(&mut self) -> Size2D<f32> { |
This comment has been minimized.
This comment has been minimized.
|
The parts that I can see look good. It seems like Window should implement WindowMethods. This is how the font stuff in servo-gfx was done. Right now there's no knowing what the platform abstract API is supposed to be without looking at the modules themselves. |
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Update the VTTCue test names
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Add proper transform support for text run shader. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/431) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedMay 9, 2013
r? @metajack