Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: Implement `text-transform`. #4311

Closed
wants to merge 1 commit into from
Closed

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Dec 10, 2014

The Unicode awareness of text-transform is implemented as well as
possible given the Rust standard library's Unicode support. In
particular, the notion of an alphabetic character is used instead of a
letter.

Gecko has a subclass of text run to handle text transforms, but I
implemented this in a simpler way.

r? @SimonSapin

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Dec 10, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3445

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@pcwalton
Copy link
Contributor Author

pcwalton commented Dec 10, 2014

re-r? @SimonSapin

@SimonSapin
Copy link
Member

SimonSapin commented Dec 10, 2014

r+ with some non-ASCII that is transformed added to uppercase and lowercase tests.

The Unicode awareness of `text-transform` is implemented as well as
possible given the Rust standard library's Unicode support. In
particular, the notion of an alphabetic character is used instead of a
letter.

Gecko has a subclass of text run to handle text transforms, but I
implemented this in a simpler way.
@pcwalton pcwalton force-pushed the pcwalton:text-transform branch from 3de54ac to 877f02f Dec 10, 2014
@pcwalton

This comment has been minimized.

Copy link
Owner Author

pcwalton commented on 877f02f Dec 10, 2014

r=SimonSapin

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 877f02f Dec 10, 2014

saw approval from SimonSapin
at pcwalton@877f02f

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 10, 2014

merging pcwalton/servo/text-transform = 877f02f into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 10, 2014

pcwalton/servo/text-transform = 877f02f merged ok, testing candidate = 9bf1d18

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 10, 2014

fast-forwarding master to auto = 9bf1d18

bors-servo pushed a commit that referenced this pull request Dec 10, 2014
The Unicode awareness of `text-transform` is implemented as well as
possible given the Rust standard library's Unicode support. In
particular, the notion of an alphabetic character is used instead of a
letter.

Gecko has a subclass of text run to handle text transforms, but I
implemented this in a simpler way.

r? @SimonSapin
@bors-servo bors-servo closed this Dec 10, 2014
@pyfisch pyfisch mentioned this pull request Jan 4, 2018
4 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.