Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplayout: Implement `text-transform`. #4311
Conversation
hoppipolla-critic-bot
commented
Dec 10, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3445 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
re-r? @SimonSapin |
|
r+ with some non-ASCII that is transformed added to uppercase and lowercase tests. |
The Unicode awareness of `text-transform` is implemented as well as possible given the Rust standard library's Unicode support. In particular, the notion of an alphabetic character is used instead of a letter. Gecko has a subclass of text run to handle text transforms, but I implemented this in a simpler way.
This comment has been minimized.
This comment has been minimized.
|
r=SimonSapin |
This comment has been minimized.
This comment has been minimized.
|
saw approval from SimonSapin |
This comment has been minimized.
This comment has been minimized.
|
merging pcwalton/servo/text-transform = 877f02f into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 9bf1d18 |
The Unicode awareness of `text-transform` is implemented as well as possible given the Rust standard library's Unicode support. In particular, the notion of an alphabetic character is used instead of a letter. Gecko has a subclass of text run to handle text transforms, but I implemented this in a simpler way. r? @SimonSapin
pcwalton commentedDec 10, 2014
The Unicode awareness of
text-transformis implemented as well aspossible given the Rust standard library's Unicode support. In
particular, the notion of an alphabetic character is used instead of a
letter.
Gecko has a subclass of text run to handle text transforms, but I
implemented this in a simpler way.
r? @SimonSapin