Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfx: Implement `box-shadow` per CSS-BACKGROUNDS. #4318

Closed
wants to merge 1 commit into from
Closed

gfx: Implement `box-shadow` per CSS-BACKGROUNDS. #4318

wants to merge 1 commit into from

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Dec 10, 2014

r? @SimonSapin
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Dec 10, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3455

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@pcwalton pcwalton force-pushed the pcwalton:box-shadow-redux branch from 21450cc to e1d8ed3 Dec 10, 2014
@SimonSapin SimonSapin mentioned this pull request Dec 15, 2014
Closed
@pcwalton pcwalton force-pushed the pcwalton:box-shadow-redux branch from e1d8ed3 to 998dde7 Dec 15, 2014
@pcwalton
Copy link
Contributor Author

pcwalton commented Dec 15, 2014

r? @SimonSapin (I have no idea why Critic decided you accepted this)
@SimonSapin
Copy link
Member

SimonSapin commented Dec 15, 2014

998dde7 looks good other than one parsing issue (details inline).
@pcwalton pcwalton force-pushed the pcwalton:box-shadow-redux branch from 52631a5 to 0cc2bbb Dec 15, 2014
bors-servo pushed a commit that referenced this pull request Dec 15, 2014
bors-servo
auto merge of #4318 : pcwalton/servo/box-shadow-redux, r=SimonSapin
Loading status checks…
388e9db 
r? @SimonSapin
components/gfx/paint_context.rs Outdated
trait DrawTargetExtensions {
/// Creates and returns a path that represents a rectangular border. Like this:
///
/// +--------------------------------+

This comment has been minimized.

Sign in to view
@SimonSapin

SimonSapin Dec 15, 2014

Member

Test failure: http://build.servo.org/builders/linux1/builds/301/steps/shell_1/logs/stdio

Indentation makes Markdown parse this as a code block, which rustdoc apparently defaults to parse as Rust code for a doc test. Try an explicit code block with a non-Rust type annotation like ````text`
@pcwalton
gfx: Implement `box-shadow` per CSS-BACKGROUNDS.
Loading status checks…
3ba0abd
@pcwalton pcwalton force-pushed the pcwalton:box-shadow-redux branch from 0cc2bbb to 3ba0abd Dec 15, 2014
@pcwalton

This comment has been minimized.

Sign in to view
Copy link
Owner Author

pcwalton commented on 3ba0abd Dec 15, 2014

r=SimonSapin

This comment has been minimized.

Sign in to view
Copy link

Manishearth replied Dec 15, 2014

@bors: retry
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 3ba0abd Dec 15, 2014

saw approval from SimonSapin
at pcwalton@3ba0abd

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

merging pcwalton/servo/box-shadow-redux = 3ba0abd into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

pcwalton/servo/box-shadow-redux = 3ba0abd merged ok, testing candidate = 57ca903

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

some tests failed:
failure: http://build.servo.org/builders/linux2/builds/302

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

pcwalton replied Dec 15, 2014

@bors: retry

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

saw approval from SimonSapin
at pcwalton@3ba0abd

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

merging pcwalton/servo/box-shadow-redux = 3ba0abd into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

pcwalton/servo/box-shadow-redux = 3ba0abd merged ok, testing candidate = 7805fe1

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

all tests pass:
success: http://build.servo.org/builders/linux1/builds/308
success: http://build.servo.org/builders/linux2/builds/307
success: http://build.servo.org/builders/android/builds/375
success: http://build.servo.org/builders/mac1/builds/524
success: http://build.servo.org/builders/mac2/builds/525

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

fast-forwarding master to auto = 7805fe1
bors-servo pushed a commit that referenced this pull request Dec 15, 2014
bors-servo
auto merge of #4318 : pcwalton/servo/box-shadow-redux, r=SimonSapin
Loading status checks…
57ca903 
r? @SimonSapin
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 3ba0abd Dec 15, 2014

saw approval from SimonSapin
at pcwalton@3ba0abd

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

merging pcwalton/servo/box-shadow-redux = 3ba0abd into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

pcwalton/servo/box-shadow-redux = 3ba0abd merged ok, testing candidate = 57ca903

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

some tests failed:
failure: http://build.servo.org/builders/linux2/builds/302

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

pcwalton replied Dec 15, 2014

@bors: retry

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

saw approval from SimonSapin
at pcwalton@3ba0abd

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

merging pcwalton/servo/box-shadow-redux = 3ba0abd into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

pcwalton/servo/box-shadow-redux = 3ba0abd merged ok, testing candidate = 7805fe1

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

all tests pass:
success: http://build.servo.org/builders/linux1/builds/308
success: http://build.servo.org/builders/linux2/builds/307
success: http://build.servo.org/builders/android/builds/375
success: http://build.servo.org/builders/mac1/builds/524
success: http://build.servo.org/builders/mac2/builds/525

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 15, 2014

fast-forwarding master to auto = 7805fe1
@pcwalton
Copy link
Contributor Author

pcwalton commented Dec 15, 2014

@bors: retry
bors-servo pushed a commit that referenced this pull request Dec 15, 2014
bors-servo
auto merge of #4318 : pcwalton/servo/box-shadow-redux, r=SimonSapin
Loading status checks…
7805fe1 
r? @SimonSapin
@bors-servo bors-servo closed this Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-gfx/rendering A-layout/uncategorized I-enhancement S-needs-code-changes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@pcwalton @hoppipolla-critic-bot @SimonSapin @bors-servo @Manishearth
You can’t perform that action at this time.