Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return real page titles and URLs for devtools tab choices. #4355

Merged
merged 1 commit into from Dec 13, 2014
Merged

Return real page titles and URLs for devtools tab choices. #4355

merged 1 commit into from Dec 13, 2014

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 12, 2014

Fixes #4167.
@snowmantw @Ms2ger
Return real page titles and URLs for devtools tab choices.
Loading status checks…
a477893 
Fixes #4167.
@Ms2ger Ms2ger mentioned this pull request Dec 12, 2014
Closed
@Ms2ger Ms2ger closed this Dec 12, 2014
@Ms2ger Ms2ger reopened this Dec 12, 2014
@metajack

This comment has been minimized.

Sign in to view
Copy link
Contributor

metajack commented on a477893 Dec 12, 2014

r+

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 12, 2014

saw approval from metajack
at a477893

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 12, 2014

merging servo/servo/devtools-title = a477893 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 12, 2014

servo/servo/devtools-title = a477893 merged ok, testing candidate = 1b99d43

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 12, 2014

some tests failed:
failure: http://build.servo.org/builders/linux2/builds/277

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 13, 2014

saw approval from metajack
at a477893

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 13, 2014

merging servo/servo/devtools-title = a477893 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 13, 2014

servo/servo/devtools-title = a477893 merged ok, testing candidate = 6362d06

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 13, 2014

all tests pass:
success: http://build.servo.org/builders/linux1/builds/284
success: http://build.servo.org/builders/linux2/builds/283
success: http://build.servo.org/builders/android/builds/351
success: http://build.servo.org/builders/mac1/builds/500
success: http://build.servo.org/builders/mac2/builds/501

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 13, 2014

fast-forwarding master to auto = 6362d06
@metajack

This comment has been minimized.

Sign in to view
Copy link
Contributor

metajack commented on a477893 Dec 12, 2014

r+

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 12, 2014

saw approval from metajack
at a477893

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 12, 2014

merging servo/servo/devtools-title = a477893 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 12, 2014

servo/servo/devtools-title = a477893 merged ok, testing candidate = 1b99d43

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 12, 2014

some tests failed:
failure: http://build.servo.org/builders/linux2/builds/277

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 13, 2014

saw approval from metajack
at a477893

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 13, 2014

merging servo/servo/devtools-title = a477893 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 13, 2014

servo/servo/devtools-title = a477893 merged ok, testing candidate = 6362d06

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 13, 2014

all tests pass:
success: http://build.servo.org/builders/linux1/builds/284
success: http://build.servo.org/builders/linux2/builds/283
success: http://build.servo.org/builders/android/builds/351
success: http://build.servo.org/builders/mac1/builds/500
success: http://build.servo.org/builders/mac2/builds/501

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 13, 2014

fast-forwarding master to auto = 6362d06
bors-servo pushed a commit that referenced this pull request Dec 12, 2014
bors-servo
auto merge of #4355 : servo/servo/devtools-title, r=metajack
Loading status checks…
1b99d43 
Fixes #4167.
bors-servo pushed a commit that referenced this pull request Dec 12, 2014
bors-servo
auto merge of #4355 : servo/servo/devtools-title, r=metajack
Loading status checks…
f3d13d0 
Fixes #4167.
bors-servo pushed a commit that referenced this pull request Dec 13, 2014
bors-servo
auto merge of #4355 : servo/servo/devtools-title, r=metajack
Loading status checks…
6362d06 
Fixes #4167.
@bors-servo bors-servo closed this Dec 13, 2014
@bors-servo bors-servo merged commit a477893 into master Dec 13, 2014
1 check passed
1 check passed
default all tests passed
@Ms2ger Ms2ger deleted the devtools-title branch Dec 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Return real page titles and URLs for devtools tab choices
5 participants
@Ms2ger @bors-servo @jdm @metajack @snowmantw
You can’t perform that action at this time.