Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMerge RootFlow into BlockFlow #436
Merged
Conversation
| @@ -105,15 +94,13 @@ impl BlockLayout for FlowContext { | |||
|
|
|||
| /* if not an anonymous block context, add in block box's widths. | |||
| these widths will not include child elements, just padding etc. */ | |||
| do self.with_block_box |box| { | |||
| self.box.map(|&box| { | |||
This comment has been minimized.
This comment has been minimized.
pcwalton
added a commit
that referenced
this pull request
May 11, 2013
Merge RootFlow into BlockFlow
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Remove previousElementSibling and nextElementSibling from DocumentType nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sethfowler commentedMay 11, 2013
RootFlow is just a tiny variant on BlockFlow, and because it's implemented in terms of BlockFlow it distorts the structure of BlockFlow. (For example, BlockFlow's methods were implemented directly on FlowContext to allow RootFlow to call them.) I've removed RootFlow, folded its behavior into BlockFlow, and given BlockFlow the structure it should have had.