Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace with_imm_node by with_base and with_mut_node by with_mut_base #437
+57
−57
Conversation
metajack
added a commit
that referenced
this pull request
May 11, 2013
Replace with_imm_node by with_base and with_mut_node by with_mut_base
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Fix shader compile error for image + clip + transform. Closes servo#437. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/447) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sethfowler commentedMay 11, 2013
This is a refactoring patch that replaces
with_imm_nodebywith_baseandwith_mut_nodebywith_mut_base. The intention is that the new names better reflect how we actually use these methods. In the case ofwith_basethe name is also shorter, which is nice.