Replace with_imm_node by with_base and with_mut_node by with_mut_base#437
Merged
metajack merged 1 commit intoservo:masterfrom May 11, 2013
Merged
Conversation
metajack
added a commit
that referenced
this pull request
May 11, 2013
Replace with_imm_node by with_base and with_mut_node by with_mut_base
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Fix shader compile error for image + clip + transform. Closes servo#437. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/447) <!-- Reviewable:end -->
jdm
pushed a commit
to jdm/servo
that referenced
this pull request
Mar 6, 2021
Update mozjs_sys to 0.61.0 Depends on servo/mozjs#147 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/437) <!-- Reviewable:end -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactoring patch that replaces
with_imm_nodebywith_baseandwith_mut_nodebywith_mut_base. The intention is that the new names better reflect how we actually use these methods. In the case ofwith_basethe name is also shorter, which is nice.