Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a replacement for Cell<SM primitive>. Fixes #4337. #4401

Closed
wants to merge 1 commit into from

Conversation

@jdm
Copy link
Member

jdm commented Dec 17, 2014

We still will need a lint to ban any further uses, but that can be a followup.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Dec 17, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3524

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member Author

jdm commented Dec 17, 2014

r? @Ms2ger

@Manishearth
Copy link
Member

Manishearth commented Dec 19, 2014

Needs rebase

@jdm

This comment has been minimized.

Copy link
Owner Author

jdm commented on 8ff3e6b Dec 19, 2014

r=Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 8ff3e6b Dec 19, 2014

saw approval from Manishearth
at jdm@8ff3e6b

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 19, 2014

merging jdm/servo/heapsm2 = 8ff3e6b into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 19, 2014

jdm/servo/heapsm2 = 8ff3e6b merged ok, testing candidate = c17d533

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 19, 2014

fast-forwarding master to auto = c17d533

bors-servo pushed a commit that referenced this pull request Dec 19, 2014
We still will need a lint to ban any further uses, but that can be a followup.
@bors-servo bors-servo closed this Dec 19, 2014
@jdm jdm deleted the jdm:heapsm2 branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.