Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate a replacement for Cell<SM primitive>. Fixes #4337. #4401
Conversation
hoppipolla-critic-bot
commented
Dec 17, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3524 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
r? @Ms2ger |
|
Needs rebase |
This comment has been minimized.
This comment has been minimized.
|
r=Manishearth |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Manishearth |
This comment has been minimized.
This comment has been minimized.
|
merging jdm/servo/heapsm2 = 8ff3e6b into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = c17d533 |
We still will need a lint to ban any further uses, but that can be a followup.
jdm commentedDec 17, 2014
We still will need a lint to ban any further uses, but that can be a followup.