Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing CSS properties and remove incorrect serialization deriving v... #4439

Closed
wants to merge 1 commit into from
Closed

Add missing CSS properties and remove incorrect serialization deriving v... #4439

wants to merge 1 commit into from

Conversation

@jdm
Copy link
Member

jdm commented Dec 19, 2014

...ia Show.
@jdm
Add missing CSS properties and remove incorrect serialization derivin…
717cb74 
…g via Show.
@jdm
Copy link
Member Author

jdm commented Dec 19, 2014

r? @SimonSapin
@SimonSapin
Copy link
Member

SimonSapin commented Dec 21, 2014

As said in #4440 I agree that the Show trait shouldn’t be used for CSS serialization, and I’ve implementing the ToCss trait in #4455. I think this PR should be rebased on top of #4455 and use ToCss. See also my comment there about using write_str and to_css when possible instead of write!.
@jdm jdm added the S-needs-rebase label Jan 9, 2015
@jdm
Copy link
Member Author

jdm commented Feb 23, 2015

@SimonSapin This PR isn't necessary any more, right? We've got full serialization for all supported properties?
@SimonSapin
Copy link
Member

SimonSapin commented Feb 23, 2015

Right, the underlying issue was fixed in #4856. Sorry I forgot to close this!
@SimonSapin SimonSapin closed this Feb 23, 2015
@jdm jdm deleted the jdm:csspropfix branch Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-needs-code-changes S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jdm @SimonSapin
You can’t perform that action at this time.