Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the argument to dispatch_event_with_target non-optional. #4443

Merged
merged 1 commit into from Dec 19, 2014

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 19, 2014

The name of the method makes it clear it's supposed to be used with a target
override, so we might as well enforce that.

The name of the method makes it clear it's supposed to be used with a target
override, so we might as well enforce that.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Dec 19, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3549

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Manishearth

This comment has been minimized.

Copy link

Manishearth commented on bce3b17 Dec 19, 2014

r+

This comment has been minimized.

Copy link
Owner Author

Ms2ger replied Dec 19, 2014

@bors: retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on bce3b17 Dec 19, 2014

saw approval from Manishearth
at Ms2ger@bce3b17

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 19, 2014

merging Ms2ger/servo/dispatch_event_with_target = bce3b17 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 19, 2014

Ms2ger/servo/dispatch_event_with_target = bce3b17 merged ok, testing candidate = 771be4d

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 19, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 19, 2014

saw approval from Manishearth
at Ms2ger@bce3b17

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 19, 2014

merging Ms2ger/servo/dispatch_event_with_target = bce3b17 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 19, 2014

Ms2ger/servo/dispatch_event_with_target = bce3b17 merged ok, testing candidate = 11b2736

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 19, 2014

fast-forwarding master to auto = 11b2736

bors-servo pushed a commit that referenced this pull request Dec 19, 2014
…shearth

The name of the method makes it clear it's supposed to be used with a target
override, so we might as well enforce that.
bors-servo pushed a commit that referenced this pull request Dec 19, 2014
…shearth

The name of the method makes it clear it's supposed to be used with a target
override, so we might as well enforce that.
@bors-servo bors-servo closed this Dec 19, 2014
@bors-servo bors-servo merged commit bce3b17 into servo:master Dec 19, 2014
1 check passed
1 check passed
default all tests passed
@Ms2ger Ms2ger deleted the Ms2ger:dispatch_event_with_target branch Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.