Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake the argument to dispatch_event_with_target non-optional. #4443
Conversation
The name of the method makes it clear it's supposed to be used with a target override, so we might as well enforce that.
hoppipolla-critic-bot
commented
Dec 19, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3549 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
Manishearth
commented on bce3b17
Dec 19, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Manishearth |
This comment has been minimized.
This comment has been minimized.
|
merging Ms2ger/servo/dispatch_event_with_target = bce3b17 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Manishearth |
This comment has been minimized.
This comment has been minimized.
|
merging Ms2ger/servo/dispatch_event_with_target = bce3b17 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 11b2736 |
…shearth The name of the method makes it clear it's supposed to be used with a target override, so we might as well enforce that.
…shearth The name of the method makes it clear it's supposed to be used with a target override, so we might as well enforce that.
bce3b17
into
servo:master
Ms2ger commentedDec 19, 2014
The name of the method makes it clear it's supposed to be used with a target
override, so we might as well enforce that.