Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify some code in ScriptTask::load. #4444

Merged
merged 1 commit into from Dec 19, 2014
Merged

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 19, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Dec 19, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3550

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm

This comment has been minimized.

Copy link

jdm commented on 10bda1a Dec 19, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 10bda1a Dec 19, 2014

saw approval from jdm
at Ms2ger@10bda1a

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 19, 2014

merging Ms2ger/servo/load-simplify = 10bda1a into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 19, 2014

Ms2ger/servo/load-simplify = 10bda1a merged ok, testing candidate = b9edc22

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 19, 2014

fast-forwarding master to auto = b9edc22

bors-servo pushed a commit that referenced this pull request Dec 19, 2014
@bors-servo bors-servo closed this Dec 19, 2014
@bors-servo bors-servo merged commit 10bda1a into servo:master Dec 19, 2014
1 check passed
1 check passed
default all tests passed
@Ms2ger Ms2ger deleted the Ms2ger:load-simplify branch Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.