Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfx: Clip the background properly when `border-radius` is used, and clean up some painting stuff. #4459

Closed
wants to merge 3 commits into from

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Dec 22, 2014

Together these improve a large number of sites: GitHub, Reddit, Wikipedia, etc.

r? @glennw

@highfive
Copy link

highfive commented Dec 22, 2014

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Dec 22, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3565

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

bors-servo pushed a commit that referenced this pull request Dec 22, 2014
Together these improve a large number of sites: GitHub, Reddit, Wikipedia, etc.

r? @glennw
pcwalton added 3 commits Dec 22, 2014
list building into multiple functions.

This should have no functional changes; it's just code cleanup.
causing elements to be randomly clipped out.

Improves Wikipedia, Reddit, etc.
Improves Reddit, GitHub, etc.
@pcwalton pcwalton force-pushed the pcwalton:border-radius-clipping branch from 3ad2dc3 to cc7cacf Dec 22, 2014
@pcwalton

This comment has been minimized.

Copy link
Owner Author

pcwalton commented on cc7cacf Dec 22, 2014

r=glennw

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on cc7cacf Dec 22, 2014

saw approval from glennw
at pcwalton@cc7cacf

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 22, 2014

merging pcwalton/servo/border-radius-clipping = cc7cacf into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 22, 2014

pcwalton/servo/border-radius-clipping = cc7cacf merged ok, testing candidate = 63a7742

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 22, 2014

fast-forwarding master to auto = 63a7742

bors-servo pushed a commit that referenced this pull request Dec 22, 2014
Together these improve a large number of sites: GitHub, Reddit, Wikipedia, etc.

r? @glennw
@bors-servo bors-servo closed this Dec 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.