Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse event polling instead of blocking when outputting to a file. #4461
Conversation
This stops some ref tests on linux blocking while waiting for user input events and never outputting the file. Also mark vertical writing test as flaky on all platforms. Due to unrelated timing reasons, this fails reliably on mac when glutin is enabled. The related bug with details on the root cause is #3926.
hoppipolla-critic-bot
commented
Dec 22, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3568 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
r? @larsbergstrom or @metajack |
This comment has been minimized.
This comment has been minimized.
larsbergstrom
commented on 2accabd
Dec 23, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
r=larsbergstrom |
This comment has been minimized.
This comment has been minimized.
|
saw approval from larsbergstrom |
This comment has been minimized.
This comment has been minimized.
|
merging glennw/servo/glutin-tests = 8e32ba9 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = b83b493 |
This stops some ref tests on linux blocking while waiting for user input events and never outputting the file. Also mark vertical writing test as flaky on all platforms. Due to unrelated timing reasons, this fails reliably on mac when glutin is enabled. The related bug with details on the root cause is #3926.
glennw commentedDec 22, 2014
This stops some ref tests on linux blocking while waiting for
user input events and never outputting the file.
Also mark vertical writing test as flaky on all platforms. Due
to unrelated timing reasons, this fails reliably on mac when glutin
is enabled. The related bug with details on the root cause is #3926.