Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use event polling instead of blocking when outputting to a file. #4461

Closed
wants to merge 2 commits into from

Conversation

@glennw
Copy link
Member

glennw commented Dec 22, 2014

This stops some ref tests on linux blocking while waiting for
user input events and never outputting the file.

Also mark vertical writing test as flaky on all platforms. Due
to unrelated timing reasons, this fails reliably on mac when glutin
is enabled. The related bug with details on the root cause is #3926.

This stops some ref tests on linux blocking while waiting for
user input events and never outputting the file.

Also mark vertical writing test as flaky on all platforms. Due
to unrelated timing reasons, this fails reliably on mac when glutin
is enabled. The related bug with details on the root cause is #3926.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Dec 22, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3568

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@glennw
Copy link
Member Author

glennw commented Dec 22, 2014

@larsbergstrom

This comment has been minimized.

Copy link

larsbergstrom commented on 2accabd Dec 23, 2014

r+

@glennw

This comment has been minimized.

Copy link
Owner

glennw commented on 8e32ba9 Dec 23, 2014

r=larsbergstrom

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 8e32ba9 Dec 23, 2014

saw approval from larsbergstrom
at glennw@8e32ba9

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 23, 2014

merging glennw/servo/glutin-tests = 8e32ba9 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 23, 2014

glennw/servo/glutin-tests = 8e32ba9 merged ok, testing candidate = b83b493

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 23, 2014

fast-forwarding master to auto = b83b493

bors-servo pushed a commit that referenced this pull request Dec 23, 2014
This stops some ref tests on linux blocking while waiting for
user input events and never outputting the file.

Also mark vertical writing test as flaky on all platforms. Due
to unrelated timing reasons, this fails reliably on mac when glutin
is enabled. The related bug with details on the root cause is #3926.
@bors-servo bors-servo closed this Dec 23, 2014
@glennw glennw deleted the glennw:glutin-tests branch Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.