Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for named deleter #4483

Merged
merged 1 commit into from Dec 29, 2014
Merged

Add support for named deleter #4483

merged 1 commit into from Dec 29, 2014

Conversation

@brunoabinader
Copy link
Contributor

brunoabinader commented Dec 26, 2014

Closes #4469.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Dec 26, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3593

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@brunoabinader
Add support for named deleter
Loading status checks…
ab618dd 
Closes #4469.
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on ab618dd Dec 29, 2014

saw approval from Ms2ger
at https://github.com/brunoabinader/servo/commit/ab618dd9c74e9c9383af8df970ae715445099bfd

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 29, 2014

merging brunoabinader/servo/named-deleter = ab618dd into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 29, 2014

brunoabinader/servo/named-deleter = ab618dd merged ok, testing candidate = f76a460

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 29, 2014

all tests pass:
success: http://build.servo.org/builders/linux1/builds/423
success: http://build.servo.org/builders/linux2/builds/422
success: http://build.servo.org/builders/android/builds/458
success: http://build.servo.org/builders/mac1/builds/639
success: http://build.servo.org/builders/mac2/builds/640

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 29, 2014

fast-forwarding master to auto = f76a460
bors-servo pushed a commit that referenced this pull request Dec 29, 2014
bors-servo
auto merge of #4483 : brunoabinader/servo/named-deleter, r=Ms2ger
Loading status checks…
f76a460 
Closes #4469.
@bors-servo bors-servo closed this Dec 29, 2014
@bors-servo bors-servo merged commit ab618dd into servo:master Dec 29, 2014
1 check passed
1 check passed
default all tests passed
@brunoabinader brunoabinader deleted the brunoabinader:named-deleter branch Dec 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement named deleters.
4 participants
@brunoabinader @hoppipolla-critic-bot @bors-servo @jdm
You can’t perform that action at this time.