New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update description in ORGANIZATION.md #4491
update description in ORGANIZATION.md #4491
Conversation
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon. |
Critic review: https://critic.hoppipolla.co.uk/r/3600 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Thanks! We'll be with you shortly. |
Great! I've left a few comments on Critic! |
a4877d2
to
1d0bc45
Compare
I update the doc as critic. I also add period mark at end of every sentence. |
Looks good! In the future, we do prefer additional commits rather than amending existing commits (as @hoppipolla-critic-bot mentioned) as it makes it easier to see what's changed. |
…r=jdm This is a short update to ORGANIZATION.md. Since I just join this project, and cannot find the entry point described in this doc, so I search git log to figure out the description of each file and directory. Any comment is welcome.
Sorry, one last detail I noticed: all of the old entries had `s surrounding the path, and that's missing on many of the new entries. Could you fix that, please? |
done. |
Thanks! |
…r=jdm This is a short update to ORGANIZATION.md. Since I just join this project, and cannot find the entry point described in this doc, so I search git log to figure out the description of each file and directory. Any comment is welcome.
This is a short update to ORGANIZATION.md. Since I just join this project, and cannot find the entry point described in this doc, so I search git log to figure out the description of each file and directory.
Any comment is welcome.