Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update description in ORGANIZATION.md #4491

Merged
merged 2 commits into from Dec 30, 2014

Conversation

yodalee
Copy link
Contributor

@yodalee yodalee commented Dec 27, 2014

This is a short update to ORGANIZATION.md. Since I just join this project, and cannot find the entry point described in this doc, so I search git log to figure out the description of each file and directory.
Any comment is welcome.

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/3600

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger Ms2ger added the S-awaiting-review There is new code that needs to be reviewed. label Dec 27, 2014
@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 27, 2014

Thanks! We'll be with you shortly.

@jdm jdm mentioned this pull request Dec 27, 2014
@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 29, 2014
@jdm
Copy link
Member

jdm commented Dec 29, 2014

Great! I've left a few comments on Critic!

@yodalee yodalee force-pushed the update-ORGANIZATION-description branch from a4877d2 to 1d0bc45 Compare December 29, 2014 22:30
@yodalee
Copy link
Contributor Author

yodalee commented Dec 29, 2014

I update the doc as critic. I also add period mark at end of every sentence.

@jdm
Copy link
Member

jdm commented Dec 30, 2014

Looks good! In the future, we do prefer additional commits rather than amending existing commits (as @hoppipolla-critic-bot mentioned) as it makes it easier to see what's changed.

@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 30, 2014
bors-servo pushed a commit that referenced this pull request Dec 30, 2014
…r=jdm

This is a short update to ORGANIZATION.md. Since I just join this project, and cannot find the entry point described in this doc, so I search git log to figure out the description of each file and directory.
Any comment is welcome.
@jdm
Copy link
Member

jdm commented Dec 30, 2014

Sorry, one last detail I noticed: all of the old entries had `s surrounding the path, and that's missing on many of the new entries. Could you fix that, please?

@yodalee
Copy link
Contributor Author

yodalee commented Dec 30, 2014

done.

@jdm
Copy link
Member

jdm commented Dec 30, 2014

Thanks!

bors-servo pushed a commit that referenced this pull request Dec 30, 2014
…r=jdm

This is a short update to ORGANIZATION.md. Since I just join this project, and cannot find the entry point described in this doc, so I search git log to figure out the description of each file and directory.
Any comment is welcome.
@bors-servo bors-servo closed this Dec 30, 2014
@bors-servo bors-servo merged commit 5912704 into servo:master Dec 30, 2014
@yodalee yodalee deleted the update-ORGANIZATION-description branch January 5, 2015 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-code-changes Changes have not yet been made that were requested by a reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants