Skip to content

Comments

Only restore rust if the backup exists.#450

Merged
metajack merged 1 commit intoservo:masterfrom
metajack:restore-fix
May 16, 2013
Merged

Only restore rust if the backup exists.#450
metajack merged 1 commit intoservo:masterfrom
metajack:restore-fix

Conversation

@metajack
Copy link
Collaborator

For #402

@bhearsum
Copy link

Worked for me.

@metajack
Copy link
Collaborator Author

brson r+ed this in irc

metajack added a commit that referenced this pull request May 16, 2013
Only restore rust if the backup exists.
@metajack metajack merged commit 01226cf into servo:master May 16, 2013
@metajack metajack deleted the restore-fix branch May 16, 2013 01:21
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
clean tests from old-tests/submission/Opera/documentwrite
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
update dependency override instructions

Can't use numbers with the snippet in the middle. Switched to regular bullets.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/450)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request Nov 5, 2019
jdm pushed a commit to jdm/servo that referenced this pull request Mar 6, 2021
Make runtime creation safe

The fundamental problem exposed in servo#22342 is that our concept of a parent runtime did not match reality. Using the first JSContext's runtime as the global parent for all subsequent contexts only makes sense if that JSContext outlives every other context. This is not guaranteed, leading to crashes when trying to use those contexts if the first context (and therefore its runtime) was destroyed.

The new design incorporates several changes for safer, more clear context and runtime management:
* in order to create a new context, either a handle to an initialized JS engine is required or a handle to an existing runtime
* all runtimes track outstanding handles that have been created, and assert if a runtime is destroyed before all of its child runtimes
* overall initialization and shutdown of the engine is controlled by the lifetime of a JSEngine value, so creating a Runtime value is now infallible

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/450)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants